linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] io-controller: including "linux/sched.h"
@ 2010-04-16  6:38 Gui Jianfeng
  2010-04-16  6:49 ` Jens Axboe
  0 siblings, 1 reply; 3+ messages in thread
From: Gui Jianfeng @ 2010-04-16  6:38 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Vivek Goyal, Divyesh Shah, linux kernel mailing list

Include sched.h explicitly since sched_clock() is called.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 block/blk-cgroup.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 83930f6..ed6590e 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -19,6 +19,7 @@
 #include <linux/slab.h>
 #include "blk-cgroup.h"
 #include <linux/genhd.h>
+#include <linux/sched.h>
 
 #define MAX_KEY_LEN 100
 
-- 
1.5.4.rc3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] io-controller: including "linux/sched.h"
  2010-04-16  6:38 [PATCH] io-controller: including "linux/sched.h" Gui Jianfeng
@ 2010-04-16  6:49 ` Jens Axboe
  2010-04-16  7:17   ` Gui Jianfeng
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2010-04-16  6:49 UTC (permalink / raw)
  To: Gui Jianfeng; +Cc: Vivek Goyal, Divyesh Shah, linux kernel mailing list

On Fri, Apr 16 2010, Gui Jianfeng wrote:
> Include sched.h explicitly since sched_clock() is called.

Why is it using sched_clock(), btw? It would seem more appropriate to
use ktime.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] io-controller: including "linux/sched.h"
  2010-04-16  6:49 ` Jens Axboe
@ 2010-04-16  7:17   ` Gui Jianfeng
  0 siblings, 0 replies; 3+ messages in thread
From: Gui Jianfeng @ 2010-04-16  7:17 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Vivek Goyal, Divyesh Shah, linux kernel mailing list

Jens Axboe wrote:
> On Fri, Apr 16 2010, Gui Jianfeng wrote:
>> Include sched.h explicitly since sched_clock() is called.
> 
> Why is it using sched_clock(), btw? It would seem more appropriate to
> use ktime.

I guess the reason is it's easy to use. :) 
Divyesh, right?

Gui
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-16  7:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-16  6:38 [PATCH] io-controller: including "linux/sched.h" Gui Jianfeng
2010-04-16  6:49 ` Jens Axboe
2010-04-16  7:17   ` Gui Jianfeng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).