* [PATCH] colibri.h: #include corrections
@ 2010-04-16 11:45 Jakob Viketoft
2010-04-16 11:48 ` Daniel Mack
0 siblings, 1 reply; 3+ messages in thread
From: Jakob Viketoft @ 2010-04-16 11:45 UTC (permalink / raw)
To: linux-kernel, Daniel Mack, Eric Miao
The use of mfp_cfg_t causes build errors without including <mach/mfp.h>.
The include for the ax88796 is kicked as well since it's inclusion is
obsoleted as adviced by Daniel Mack.
CC: stable@kernel.org
CC: Daniel Mack <daniel@caiaq.de>
CC: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by Jakob Viketoft <jakob.viketoft@bitsim.com>
--- a/arch/arm/mach-pxa/include/mach/colibri.h 2010-03-15
17:09:39.000000000 +0100
+++ b/arch/arm/mach-pxa/include/mach/colibri.h 2010-04-16
13:30:43.000000000 +0200
@@ -1,7 +1,7 @@
#ifndef _COLIBRI_H_
#define _COLIBRI_H_
-#include <net/ax88796.h>
+#include <mach/mfp.h>
/*
* common settings for all modules
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] colibri.h: #include corrections
2010-04-16 11:45 [PATCH] colibri.h: #include corrections Jakob Viketoft
@ 2010-04-16 11:48 ` Daniel Mack
2010-04-16 11:52 ` Jakob Viketoft
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mack @ 2010-04-16 11:48 UTC (permalink / raw)
To: Jakob Viketoft; +Cc: linux-kernel, Eric Miao
On Fri, Apr 16, 2010 at 01:45:48PM +0200, Jakob Viketoft wrote:
> The use of mfp_cfg_t causes build errors without including
> <mach/mfp.h>. The include for the ax88796 is kicked as well since
> it's inclusion is obsoleted as adviced by Daniel Mack.
Argh, I'm sorry. This time, I was too fast. The ax88796 must stay, I
overlooked the use of ax_plat_data.
Daniel
> CC: stable@kernel.org
> CC: Daniel Mack <daniel@caiaq.de>
> CC: Eric Miao <eric.y.miao@gmail.com>
> Signed-off-by Jakob Viketoft <jakob.viketoft@bitsim.com>
> --- a/arch/arm/mach-pxa/include/mach/colibri.h 2010-03-15
> 17:09:39.000000000 +0100
> +++ b/arch/arm/mach-pxa/include/mach/colibri.h 2010-04-16
> 13:30:43.000000000 +0200
> @@ -1,7 +1,7 @@
> #ifndef _COLIBRI_H_
> #define _COLIBRI_H_
>
> -#include <net/ax88796.h>
> +#include <mach/mfp.h>
>
> /*
> * common settings for all modules
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] colibri.h: #include corrections
2010-04-16 11:48 ` Daniel Mack
@ 2010-04-16 11:52 ` Jakob Viketoft
0 siblings, 0 replies; 3+ messages in thread
From: Jakob Viketoft @ 2010-04-16 11:52 UTC (permalink / raw)
To: daniel; +Cc: linux-kernel, Eric Miao
Daniel Mack wrote:
> On Fri, Apr 16, 2010 at 01:45:48PM +0200, Jakob Viketoft wrote:
>> The use of mfp_cfg_t causes build errors without including
>> <mach/mfp.h>. The include for the ax88796 is kicked as well since
>> it's inclusion is obsoleted as adviced by Daniel Mack.
>
> Argh, I'm sorry. This time, I was too fast. The ax88796 must stay, I
> overlooked the use of ax_plat_data.
>
> Daniel
There's gremlins in here somewhere, I'm sure. ;) I'll try one more time...
/Jakob
>
>> CC: stable@kernel.org
>> CC: Daniel Mack <daniel@caiaq.de>
>> CC: Eric Miao <eric.y.miao@gmail.com>
>> Signed-off-by Jakob Viketoft <jakob.viketoft@bitsim.com>
>
>> --- a/arch/arm/mach-pxa/include/mach/colibri.h 2010-03-15
>> 17:09:39.000000000 +0100
>> +++ b/arch/arm/mach-pxa/include/mach/colibri.h 2010-04-16
>> 13:30:43.000000000 +0200
>> @@ -1,7 +1,7 @@
>> #ifndef _COLIBRI_H_
>> #define _COLIBRI_H_
>>
>> -#include <net/ax88796.h>
>> +#include <mach/mfp.h>
>>
>> /*
>> * common settings for all modules
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-16 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-16 11:45 [PATCH] colibri.h: #include corrections Jakob Viketoft
2010-04-16 11:48 ` Daniel Mack
2010-04-16 11:52 ` Jakob Viketoft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).