* [PATCH] kvm: do not need hardware_disable when CPU_UP_CANCELED
@ 2010-04-17 9:00 Lai Jiangshan
2010-04-21 8:41 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2010-04-17 9:00 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti, LKML, kvm
When CPU_UP_CANCELED, hardware_enable() has not been called at the CPU
which is going up because raw_notifier_call_chain(CPU_ONLINE)
has not been called for this cpu.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 5a0cd19..b03f863 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1921,11 +1921,6 @@ static int kvm_cpu_hotplug(struct notifier_block *notifier, unsigned long val,
cpu);
hardware_disable(NULL);
break;
- case CPU_UP_CANCELED:
- printk(KERN_INFO "kvm: disabling virtualization on CPU%d\n",
- cpu);
- smp_call_function_single(cpu, hardware_disable, NULL, 1);
- break;
case CPU_ONLINE:
printk(KERN_INFO "kvm: enabling virtualization on CPU%d\n",
cpu);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: do not need hardware_disable when CPU_UP_CANCELED
2010-04-17 9:00 [PATCH] kvm: do not need hardware_disable when CPU_UP_CANCELED Lai Jiangshan
@ 2010-04-21 8:41 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-04-21 8:41 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: Marcelo Tosatti, LKML, kvm
On 04/17/2010 12:00 PM, Lai Jiangshan wrote:
> When CPU_UP_CANCELED, hardware_enable() has not been called at the CPU
> which is going up because raw_notifier_call_chain(CPU_ONLINE)
> has not been called for this cpu.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-21 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-17 9:00 [PATCH] kvm: do not need hardware_disable when CPU_UP_CANCELED Lai Jiangshan
2010-04-21 8:41 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).