linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Ubuntu patch enabling speedstep for sonoma processors
@ 2010-06-24 15:50 Ozan Çağlayan
  2010-06-25  0:29 ` Robert Hancock
  0 siblings, 1 reply; 2+ messages in thread
From: Ozan Çağlayan @ 2010-06-24 15:50 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ubuntu Kernel Team, Linux ACPI

Hi,

The following patch enables speedstep for sonoma processors:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-maverick.git;a=blobdiff;f=arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c;h=ee4e9f8050752923f9671f61ffbea662bc9ad12a;hp=9b1ff37de46ae6a729f48d2d94ad30548806884d;hb=23120eb5ae5a12924565e8af3d946a015e1caaf9;hpb=215cc71ef0b26b9434404f387681d9bd173d2434

The patch never got accepted by upstream after some discussions:

http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-06/msg01078.html

"""
This patch has been floating around for years.
So long, I've forgotten the original reason it wasn't accepted.
It had something to do with it working for some users, but not others,
and we can't detect the 'not working' case.

speedstep-centrino is also deprecated in favour of acpi-cpufreq for some time.
If acpi isn't working on these machines, we should find out why.

Dave Jones
"""

"""
My recollection is that we had no way to work out which voltage table
was appropriate for a given CPU, so there was a risk of us either over-
or under-volting the chip. Doing it via ACPI is safe.

Matthew Garrett
"""

I have bug report from a user which complains that frequency scaling is not available
on its computer. This patch fixes the issue but seen the discussions there should be a
better and more correct way to fix the issue.

What should I do in order to debug and try to fix it?

And also seen that Ubuntu carries this patch for a relatively long time, did you see
any negative effect like the aforementioned risk of over/under-volting the chip?

Thanks
Ozan Caglayan



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Ubuntu patch enabling speedstep for sonoma processors
  2010-06-24 15:50 Ubuntu patch enabling speedstep for sonoma processors Ozan Çağlayan
@ 2010-06-25  0:29 ` Robert Hancock
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Hancock @ 2010-06-25  0:29 UTC (permalink / raw)
  To: Ozan Çağlayan; +Cc: linux-kernel, Ubuntu Kernel Team, Linux ACPI

On 06/24/2010 09:50 AM, Ozan Çağlayan wrote:
> Hi,
>
> The following patch enables speedstep for sonoma processors:
> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-maverick.git;a=blobdiff;f=arch/x86/kernel/cpu/cpufreq/speedstep-centrino.c;h=ee4e9f8050752923f9671f61ffbea662bc9ad12a;hp=9b1ff37de46ae6a729f48d2d94ad30548806884d;hb=23120eb5ae5a12924565e8af3d946a015e1caaf9;hpb=215cc71ef0b26b9434404f387681d9bd173d2434
>
> The patch never got accepted by upstream after some discussions:
>
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-06/msg01078.html
>
> """
> This patch has been floating around for years.
> So long, I've forgotten the original reason it wasn't accepted.
> It had something to do with it working for some users, but not others,
> and we can't detect the 'not working' case.
>
> speedstep-centrino is also deprecated in favour of acpi-cpufreq for some time.
> If acpi isn't working on these machines, we should find out why.
>
> Dave Jones
> """
>
> """
> My recollection is that we had no way to work out which voltage table
> was appropriate for a given CPU, so there was a risk of us either over-
> or under-volting the chip. Doing it via ACPI is safe.
>
> Matthew Garrett
> """
>
> I have bug report from a user which complains that frequency scaling is not available
> on its computer. This patch fixes the issue but seen the discussions there should be a
> better and more correct way to fix the issue.
>
> What should I do in order to debug and try to fix it?
>
> And also seen that Ubuntu carries this patch for a relatively long time, did you see
> any negative effect like the aforementioned risk of over/under-volting the chip?

The acpidump from that system would be a good start, to figure out why 
acpi-cpufreq isn't working..

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-25  0:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-24 15:50 Ubuntu patch enabling speedstep for sonoma processors Ozan Çağlayan
2010-06-25  0:29 ` Robert Hancock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).