From: Jan Kiszka <jan.kiszka@web.de>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [PATCH] intel-iommu: Fix use after release during device attach
Date: Tue, 02 Nov 2010 08:05:51 +0100 [thread overview]
Message-ID: <4CCFB84F.6050102@web.de> (raw)
From: Jan Kiszka <jan.kiszka@siemens.com>
Obtail the new pgd pointer before releasing the page containing this
value.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Who is taking care of this? The kvm tree?
drivers/pci/intel-iommu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index 4789f8e..35463dd 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct iommu_domain *domain,
pte = dmar_domain->pgd;
if (dma_pte_present(pte)) {
- free_pgtable_page(dmar_domain->pgd);
dmar_domain->pgd = (struct dma_pte *)
phys_to_virt(dma_pte_addr(pte));
+ free_pgtable_page(pte);
}
dmar_domain->agaw--;
}
--
1.7.1
next reply other threads:[~2010-11-02 7:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 7:05 Jan Kiszka [this message]
2010-11-02 7:31 ` [PATCH] intel-iommu: Fix use after release during device attach Sheng Yang
2010-11-02 7:46 ` Jan Kiszka
2010-11-02 7:57 ` Sheng Yang
2010-11-02 8:00 ` Sheng Yang
2010-11-14 9:18 ` Jan Kiszka
2010-12-10 8:36 ` Jan Kiszka
2010-12-10 18:44 ` Chris Wright
2011-01-04 10:42 ` Jan Kiszka
2011-04-21 12:32 ` [PATCH v2] " Jan Kiszka
2011-04-21 14:02 ` Chris Wright
2011-04-21 14:28 ` Alex Williamson
2011-04-21 15:42 ` David Woodhouse
2011-04-21 16:14 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CCFB84F.6050102@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).