From: Jan Kiszka <jan.kiszka@web.de>
To: Chris Wright <chrisw@sous-sol.org>,
David Woodhouse <David.Woodhouse@intel.com>
Cc: Sheng Yang <sheng@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org,
Marcelo Tosatti <mtosatti@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] intel-iommu: Fix use after release during device attach
Date: Tue, 04 Jan 2011 11:42:44 +0100 [thread overview]
Message-ID: <4D22F9A4.3050807@web.de> (raw)
In-Reply-To: <20101210184402.GE4040@sequoia.sous-sol.org>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
Am 10.12.2010 19:44, Chris Wright wrote:
> * Jan Kiszka (jan.kiszka@siemens.com) wrote:
>>>>> --- a/drivers/pci/intel-iommu.c
>>>>> +++ b/drivers/pci/intel-iommu.c
>>>>> @@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct
>>>>> iommu_domain *domain,
>>>>>
>>>>> pte = dmar_domain->pgd;
>>>>> if (dma_pte_present(pte)) {
>>>>> - free_pgtable_page(dmar_domain->pgd);
>>>>> dmar_domain->pgd = (struct dma_pte *)
>>>>> phys_to_virt(dma_pte_addr(pte));
>
> While here, might as well remove the unnecessary cast.
>
>>>>> + free_pgtable_page(pte);
>>>>> }
>>>>> dmar_domain->agaw--;
>>>>> }
>>>>
>>>> Reviewed-by: Sheng Yang <sheng@linux.intel.com>
>
> Acked-by: Chris Wright <chrisw@sous-sol.org>
>
>>>> CC iommu mailing list and David.
>>>
>>> Ping...
>>>
>>> I think this fix also qualifies for stable (.35 and .36).
>>>
>>
>> Still not merged?
>
> David, do you plan to pick this one up?
>
> thanks,
> -chris
Hmm, still no reaction. Trying David's Intel address now...
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-01-04 10:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 7:05 [PATCH] intel-iommu: Fix use after release during device attach Jan Kiszka
2010-11-02 7:31 ` Sheng Yang
2010-11-02 7:46 ` Jan Kiszka
2010-11-02 7:57 ` Sheng Yang
2010-11-02 8:00 ` Sheng Yang
2010-11-14 9:18 ` Jan Kiszka
2010-12-10 8:36 ` Jan Kiszka
2010-12-10 18:44 ` Chris Wright
2011-01-04 10:42 ` Jan Kiszka [this message]
2011-04-21 12:32 ` [PATCH v2] " Jan Kiszka
2011-04-21 14:02 ` Chris Wright
2011-04-21 14:28 ` Alex Williamson
2011-04-21 15:42 ` David Woodhouse
2011-04-21 16:14 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D22F9A4.3050807@web.de \
--to=jan.kiszka@web.de \
--cc=David.Woodhouse@intel.com \
--cc=avi@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).