* [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad
@ 2010-12-08 23:08 Chase Douglas
2010-12-09 13:41 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Chase Douglas @ 2010-12-08 23:08 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Michael Poole, linux-input, linux-kernel
With the recent switch to having the hid layer handle standard axis
initialization, the Magic Trackpad now reports relative axes. This would
be fine in the normal mode, but the driver puts the device in multitouch
mode where no relative events are generated. Also, userspace software
depends on accurate axis information for device type detection. Thus,
ignoring the relative axes from the Magic Trackpad is best.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
drivers/hid/hid-magicmouse.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index e6dc151..ed732b7 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -433,6 +433,11 @@ static int magicmouse_input_mapping(struct hid_device *hdev,
if (!msc->input)
msc->input = hi->input;
+ /* Magic Trackpad does not give relative data after switching to MT */
+ if (hi->input->id.product == USB_DEVICE_ID_APPLE_MAGICTRACKPAD &&
+ field->flags & HID_MAIN_ITEM_RELATIVE)
+ return -1;
+
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad
2010-12-08 23:08 [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad Chase Douglas
@ 2010-12-09 13:41 ` Jiri Kosina
2010-12-09 15:13 ` Chase Douglas
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2010-12-09 13:41 UTC (permalink / raw)
To: Chase Douglas; +Cc: Michael Poole, linux-input, linux-kernel
On Wed, 8 Dec 2010, Chase Douglas wrote:
> With the recent switch to having the hid layer handle standard axis
> initialization, the Magic Trackpad now reports relative axes. This would
> be fine in the normal mode, but the driver puts the device in multitouch
> mode where no relative events are generated. Also, userspace software
> depends on accurate axis information for device type detection. Thus,
> ignoring the relative axes from the Magic Trackpad is best.
Applied, thank you. I take it this should better go into .37 still, right?
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad
2010-12-09 13:41 ` Jiri Kosina
@ 2010-12-09 15:13 ` Chase Douglas
2011-01-03 22:13 ` Chase Douglas
0 siblings, 1 reply; 5+ messages in thread
From: Chase Douglas @ 2010-12-09 15:13 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Michael Poole, linux-input, linux-kernel
On 12/09/2010 05:41 AM, Jiri Kosina wrote:
> On Wed, 8 Dec 2010, Chase Douglas wrote:
>
>> With the recent switch to having the hid layer handle standard axis
>> initialization, the Magic Trackpad now reports relative axes. This would
>> be fine in the normal mode, but the driver puts the device in multitouch
>> mode where no relative events are generated. Also, userspace software
>> depends on accurate axis information for device type detection. Thus,
>> ignoring the relative axes from the Magic Trackpad is best.
>
> Applied, thank you. I take it this should better go into .37 still, right?
Yes, please.
Thanks,
-- Chase
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad
2010-12-09 15:13 ` Chase Douglas
@ 2011-01-03 22:13 ` Chase Douglas
2011-01-04 10:25 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Chase Douglas @ 2011-01-03 22:13 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Michael Poole, linux-input, linux-kernel
On 12/09/2010 10:13 AM, Chase Douglas wrote:
> On 12/09/2010 05:41 AM, Jiri Kosina wrote:
>> On Wed, 8 Dec 2010, Chase Douglas wrote:
>>
>>> With the recent switch to having the hid layer handle standard axis
>>> initialization, the Magic Trackpad now reports relative axes. This would
>>> be fine in the normal mode, but the driver puts the device in multitouch
>>> mode where no relative events are generated. Also, userspace software
>>> depends on accurate axis information for device type detection. Thus,
>>> ignoring the relative axes from the Magic Trackpad is best.
>>
>> Applied, thank you. I take it this should better go into .37 still, right?
>
> Yes, please.
Jiri,
It looks like this never got pushed to .37. Can you add "Cc:
stable@kernel.org" to the SOB area and push it?
Thanks,
-- Chase
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad
2011-01-03 22:13 ` Chase Douglas
@ 2011-01-04 10:25 ` Jiri Kosina
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2011-01-04 10:25 UTC (permalink / raw)
To: Chase Douglas; +Cc: Michael Poole, linux-input, linux-kernel
On Mon, 3 Jan 2011, Chase Douglas wrote:
> >>> With the recent switch to having the hid layer handle standard axis
> >>> initialization, the Magic Trackpad now reports relative axes. This would
> >>> be fine in the normal mode, but the driver puts the device in multitouch
> >>> mode where no relative events are generated. Also, userspace software
> >>> depends on accurate axis information for device type detection. Thus,
> >>> ignoring the relative axes from the Magic Trackpad is best.
> >>
> >> Applied, thank you. I take it this should better go into .37 still, right?
> >
> > Yes, please.
>
> Jiri,
>
> It looks like this never got pushed to .37. Can you add "Cc:
> stable@kernel.org" to the SOB area and push it?
Hi Chase,
I am not rebasing my tree, so it's not easy to add Cc: stable@kernel.org
to the commit once it has been mirrored out.
But I have this commit in my list to send it to -stable once it goes to
Linus, manually.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-04 10:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-08 23:08 [PATCH] HID: magicmouse: Don't report REL_{X,Y} for Magic Trackpad Chase Douglas
2010-12-09 13:41 ` Jiri Kosina
2010-12-09 15:13 ` Chase Douglas
2011-01-03 22:13 ` Chase Douglas
2011-01-04 10:25 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).