linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] kbuild: don't warn about include/linux/version.h not including itself
@ 2011-04-26 23:07 Peter Foley
  2011-04-29 13:47 ` Michal Marek
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2011-04-26 23:07 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-kbuild, Michal Marek

This patch makes checkversion.pl not warn that include/linux/version.h
dosen't include itself.

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 scripts/checkversion.pl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
index b444e89..cf4b1dc 100755
--- a/scripts/checkversion.pl
+++ b/scripts/checkversion.pl
@@ -12,6 +12,8 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    if($file !~ "include/linux/version\.h")
+    {
     # Open this file.
     open( my $f, '<', $file )
       or die "Can't open $file: $!\n";
@@ -67,4 +69,5 @@ foreach my $file (@ARGV) {
     }
 
     close($f);
+    }
 }
-- 
1.7.5.rc1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] kbuild: don't warn about include/linux/version.h not including itself
  2011-04-26 23:07 [PATCH V2] kbuild: don't warn about include/linux/version.h not including itself Peter Foley
@ 2011-04-29 13:47 ` Michal Marek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2011-04-29 13:47 UTC (permalink / raw)
  To: Peter Foley; +Cc: linux-kernel, linux-kbuild

On Tue, Apr 26, 2011 at 07:07:56PM -0400, Peter Foley wrote:
> This patch makes checkversion.pl not warn that include/linux/version.h
> dosen't include itself.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
>  scripts/checkversion.pl |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
> index b444e89..cf4b1dc 100755
> --- a/scripts/checkversion.pl
> +++ b/scripts/checkversion.pl
> @@ -12,6 +12,8 @@ $| = 1;
>  my $debugging;
>  
>  foreach my $file (@ARGV) {
> +    if($file !~ "include/linux/version\.h")
> +    {
>      # Open this file.

Enclosing the block in another pair of {...} is ugly, I changed it to


diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
index b444e89..5e490a8 100755
--- a/scripts/checkversion.pl
+++ b/scripts/checkversion.pl
@@ -12,6 +12,7 @@ $| = 1;
 my $debugging;
 
 foreach my $file (@ARGV) {
+    next if $file =~ "include/linux/version\.h";
     # Open this file.
     open( my $f, '<', $file )
       or die "Can't open $file: $!\n";

and pushed to kbuild-2.6.git#misc.

Michal

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-29 13:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-26 23:07 [PATCH V2] kbuild: don't warn about include/linux/version.h not including itself Peter Foley
2011-04-29 13:47 ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).