From: Tim Bird <tim.bird@am.sony.com>
To: Greg KH <greg@kroah.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Anders Kaseorg <andersk@ksplice.com>,
Tim Abbott <tabbott@ksplice.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Embedded <linux-embedded@vger.kernel.org>,
Jason Wessel <jason.wessel@windriver.com>,
Dirk Behme <dirk.behme@googlemail.com>
Subject: Re: [PATCH] module: Use binary search in lookup_symbol()
Date: Tue, 17 May 2011 16:33:07 -0700 [thread overview]
Message-ID: <4DD305B3.3000707@am.sony.com> (raw)
In-Reply-To: <20110517232241.GA19140@kroah.com>
On 05/17/2011 04:22 PM, Greg KH wrote:
> On Tue, May 17, 2011 at 10:56:03PM +0200, Alessio Igor Bogani wrote:
>> This work was supported by a hardware donation from the CE Linux Forum.
>>
>> Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
>> ---
>
> That's nice, but _why_ do this change? What does it buy us?
>
> Please explain why you make a change, not just who sponsored the change,
> that's not very interesting to developers.
Just a note here on the attribution...
Alessio - you can remove the "hardware donation from CELF" line
after the first submission or so. It doesn't need to be on
every submission of the patch set, and it doesn't need to go into
the commit message for the patch set. We only want it associated
with the patch set somewhere Google-able (like LKML).
That said, I can answer Greg's question. This is to speed up
the symbol resolution on module loading. The last numbers I
saw showed a reduction of about 15-20% for the module load
time, for large-ish modules. Of course this is highly dependent
on the size of the modules, what they do at load time, and how many
symbols are looked up to link them into the kernel.
Alessio - do you have any timings you can share for the speedup?
-- Tim
=============================
Tim Bird
Architecture Group Chair, CE Workgroup of the Linux Foundation
Senior Staff Engineer, Sony Network Entertainment
=============================
next prev parent reply other threads:[~2011-05-17 23:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 20:42 [PATCH] module: Use binary search in lookup_symbol() Alessio Igor Bogani
2011-05-04 15:34 ` Dirk Behme
2011-05-04 17:30 ` Alessio Igor Bogani
2011-05-16 15:36 ` Dirk Behme
2011-05-16 18:02 ` Anders Kaseorg
2011-05-16 20:23 ` Alessio Igor Bogani
2011-05-16 21:01 ` Joe Perches
2011-05-16 21:08 ` Joe Perches
2011-05-17 3:52 ` Rusty Russell
2011-05-17 19:18 ` Dirk Behme
2011-05-17 19:41 ` Alessio Igor Bogani
2011-05-17 20:56 ` Alessio Igor Bogani
2011-05-17 23:22 ` Greg KH
2011-05-17 23:33 ` Tim Bird [this message]
2011-05-18 7:54 ` Christoph Hellwig
2011-05-18 17:00 ` Tim Bird
2011-05-18 19:21 ` Greg KH
2011-05-18 21:10 ` module boot time (was Re: [PATCH] module: Use binary search in lookup_symbol()) Tim Bird
2011-05-18 21:34 ` Greg KH
2011-05-19 19:56 ` Jeff Mahoney
2011-05-20 21:29 ` Tim Bird
2011-05-21 14:23 ` Jeff Mahoney
2011-05-18 18:55 ` Alessio Igor Bogani
2011-05-18 19:22 ` your mail Greg KH
2011-05-18 20:35 ` Alessio Igor Bogani
2011-05-18 20:35 ` [PATCH] module: Use binary search in lookup_symbol() Alessio Igor Bogani
2011-05-18 1:07 ` Rusty Russell
2011-05-18 15:26 ` Dirk Behme
2011-05-19 7:26 ` Rusty Russell
2011-05-18 1:10 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD305B3.3000707@am.sony.com \
--to=tim.bird@am.sony.com \
--cc=abogani@kernel.org \
--cc=andersk@ksplice.com \
--cc=dirk.behme@googlemail.com \
--cc=greg@kroah.com \
--cc=jason.wessel@windriver.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).