* Re: [PATCH 3.3-rc1] PM / Sleep: Fix read_unlock_usermodehelper() call.
[not found] <201201230449.q0N4npAa029457@www262.sakura.ne.jp>
@ 2012-01-23 5:49 ` Srivatsa S. Bhat
2012-01-23 21:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Srivatsa S. Bhat @ 2012-01-23 5:49 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: rjw, linux-kernel, Linux PM mailing list
On 01/23/2012 10:19 AM, Tetsuo Handa wrote:
> Commit b298d289
> "PM / Sleep: Fix freezer failures due to racy usermodehelper_is_disabled()"
> added read_unlock_usermodehelper() but read_unlock_usermodehelper() is called
> without read_lock_usermodehelper() when kmalloc() failed.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> -----
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks for catching this!
Regards,
Srivatsa S. Bhat
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index 26ab358..6c9387d 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -525,8 +525,7 @@ static int _request_firmware(const struct firmware **firmware_p,
> if (!firmware) {
> dev_err(device, "%s: kmalloc(struct firmware) failed\n",
> __func__);
> - retval = -ENOMEM;
> - goto out;
> + return -ENOMEM;
> }
>
> if (fw_get_builtin_firmware(firmware, name)) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3.3-rc1] PM / Sleep: Fix read_unlock_usermodehelper() call.
2012-01-23 5:49 ` [PATCH 3.3-rc1] PM / Sleep: Fix read_unlock_usermodehelper() call Srivatsa S. Bhat
@ 2012-01-23 21:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-01-23 21:09 UTC (permalink / raw)
To: Srivatsa S. Bhat; +Cc: Tetsuo Handa, linux-kernel, Linux PM mailing list
On Monday, January 23, 2012, Srivatsa S. Bhat wrote:
> On 01/23/2012 10:19 AM, Tetsuo Handa wrote:
>
> > Commit b298d289
> > "PM / Sleep: Fix freezer failures due to racy usermodehelper_is_disabled()"
> > added read_unlock_usermodehelper() but read_unlock_usermodehelper() is called
> > without read_lock_usermodehelper() when kmalloc() failed.
> >
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > -----
>
>
> Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Applied.
Thanks,
Rafael
> > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> > index 26ab358..6c9387d 100644
> > --- a/drivers/base/firmware_class.c
> > +++ b/drivers/base/firmware_class.c
> > @@ -525,8 +525,7 @@ static int _request_firmware(const struct firmware **firmware_p,
> > if (!firmware) {
> > dev_err(device, "%s: kmalloc(struct firmware) failed\n",
> > __func__);
> > - retval = -ENOMEM;
> > - goto out;
> > + return -ENOMEM;
> > }
> >
> > if (fw_get_builtin_firmware(firmware, name)) {
> >
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-23 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201201230449.q0N4npAa029457@www262.sakura.ne.jp>
2012-01-23 5:49 ` [PATCH 3.3-rc1] PM / Sleep: Fix read_unlock_usermodehelper() call Srivatsa S. Bhat
2012-01-23 21:09 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).