* [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module
@ 2012-01-24 20:37 Fabio Estevam
2012-01-24 20:49 ` Mark Brown
2012-01-24 22:19 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2012-01-24 20:37 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, rdunlap, Fabio Estevam
Fix the following build error when mc138xxx driver is built as module:
ERROR: "mc13xxx_parse_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
ERROR: "mc13xxx_get_num_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/regulator/mc13xxx-regulator-core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index 80ecafe..62dcd0a 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -254,6 +254,7 @@ int __devinit mc13xxx_get_num_regulators_dt(struct platform_device *pdev)
return num;
}
+EXPORT_SYMBOL_GPL(mc13xxx_get_num_regulators_dt);
struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
struct platform_device *pdev, struct mc13xxx_regulator *regulators,
@@ -291,6 +292,7 @@ struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
return data;
}
+EXPORT_SYMBOL_GPL(mc13xxx_parse_regulators_dt);
#endif
MODULE_LICENSE("GPL v2");
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module
2012-01-24 20:37 [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module Fabio Estevam
@ 2012-01-24 20:49 ` Mark Brown
2012-01-24 22:19 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-01-24 20:49 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-kernel, rdunlap
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
On Tue, Jan 24, 2012 at 06:37:16PM -0200, Fabio Estevam wrote:
> Fix the following build error when mc138xxx driver is built as module:
>
> ERROR: "mc13xxx_parse_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
> ERROR: "mc13xxx_get_num_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
Applied, thanks for the quick response.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module
2012-01-24 20:37 [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module Fabio Estevam
2012-01-24 20:49 ` Mark Brown
@ 2012-01-24 22:19 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2012-01-24 22:19 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-kernel, broonie
On 01/24/2012 12:37 PM, Fabio Estevam wrote:
> Fix the following build error when mc138xxx driver is built as module:
>
> ERROR: "mc13xxx_parse_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
> ERROR: "mc13xxx_get_num_regulators_dt" [drivers/regulator/mc13892-regulator.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/regulator/mc13xxx-regulator-core.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index 80ecafe..62dcd0a 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -254,6 +254,7 @@ int __devinit mc13xxx_get_num_regulators_dt(struct platform_device *pdev)
>
> return num;
> }
> +EXPORT_SYMBOL_GPL(mc13xxx_get_num_regulators_dt);
>
> struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
> struct platform_device *pdev, struct mc13xxx_regulator *regulators,
> @@ -291,6 +292,7 @@ struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
>
> return data;
> }
> +EXPORT_SYMBOL_GPL(mc13xxx_parse_regulators_dt);
> #endif
>
> MODULE_LICENSE("GPL v2");
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-24 21:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-24 20:37 [PATCH] regulator: mc13xxx-regulator-core: Fix the build when driver is selected as module Fabio Estevam
2012-01-24 20:49 ` Mark Brown
2012-01-24 22:19 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).