linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	dm-devel@redhat.com
Subject: Re: [PATCH] block: add missing block_bio_complete() tracepoint
Date: Mon, 30 Jan 2012 14:51:43 +0900	[thread overview]
Message-ID: <4F262FEF.9020406@gmail.com> (raw)
In-Reply-To: <20120130025326.GI17211@htj.dyndns.org>

Hi,

2012-01-30 11:53 AM, Tejun Heo wrote:
> Hello,
>
> On Mon, Jan 30, 2012 at 11:49:43 AM +0900, Namhyung Kim wrote:
>> Yes, blktrace will see both of completions for rq and bio's it
>> contains from now on, and I thought it's your intention? For the
>> bounced bio's, it'll see one more completion per bio.
>
> Umm... no, blktrace users shouldn't see confusing outputs.  My point
> was that we should leave raw tracepoints as raw monitor points so that
> they can provide raw data to different users and filter from
> blktrace.c so that the existing users aren't disturbed.
>

That means blktrace should not be changed, and not see duplicated 
completions for rq based drivers at all?

Thanks,
Namhyung

  reply	other threads:[~2012-01-30  5:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-29  9:41 [PATCH] block: add missing block_bio_complete() tracepoint Namhyung Kim
2012-01-29 19:24 ` Tejun Heo
2012-01-30  1:44   ` Namhyung Kim
2012-01-30  1:47     ` Tejun Heo
2012-01-30  2:22       ` Namhyung Kim
2012-01-30  2:30         ` Tejun Heo
2012-01-30  2:49           ` Namhyung Kim
2012-01-30  2:53             ` Tejun Heo
2012-01-30  5:51               ` Namhyung Kim [this message]
2012-01-30  5:54                 ` Tejun Heo
2012-01-30  6:02                   ` Namhyung Kim
2012-01-30  6:38 ` Namhyung Kim
2012-01-30 17:05   ` Tejun Heo
2012-01-31  6:30     ` Namhyung Kim
2012-01-31 10:39       ` Tejun Heo
2012-02-01  2:18         ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F262FEF.9020406@gmail.com \
    --to=namhyung@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).