archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <>
To: Arnaldo Carvalho de Melo <>
Cc: Andi Kleen <>,
Subject: Re: [PATCH] perf tools: remove .. in perf includes/
Date: Mon, 30 Jan 2012 13:45:11 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 1/30/2012 11:14 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 20, 2012 at 12:36:44PM -0800, Andi Kleen escreveu:
>> From: Andi Kleen<>
>> The perf user space has a lot of includes with ugly .. chains. This also
>> makes it impossible to include any perf files from other code.
>> I think the original reason for this were some wrapper include files
>> for the kernel includes, and the explicit paths were needed to avoid
>> endless recursion. A better way to handle this is #include_next
>> - Add all the relevant directories as -I in the Makefile
>> - Remove (near) all the .. in include statements
>> - Remove unnecessary wrappers that do nothing
>> - Fix up some fallout
>> This makes the code more pleasant to read.
>> I did it all in one big patch to keep bisectability.
> It builds, but breaks this:

Hmm cannot reproduce. The extra tarball builds fine and includes memset_64.S
with my patch on Linus latest.


  reply	other threads:[~2012-01-30 21:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 20:36 [PATCH] perf tools: remove .. in perf includes/ Andi Kleen
2012-01-30 19:14 ` Arnaldo Carvalho de Melo
2012-01-30 21:45   ` Andi Kleen [this message]
2012-01-30 23:57     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).