linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: restore pin naming
@ 2012-02-01 17:15 Linus Walleij
  2012-02-01 17:33 ` Stephen Warren
  2012-02-01 19:18 ` Sergei Shtylyov
  0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2012-02-01 17:15 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel
  Cc: Stephen Warren, Grant Likely, Barry Song, Shawn Guo,
	Thomas Abraham, Dong Aisheng, Rajendra Nayak, Haojian Zhuang,
	Linus Walleij

From: Linus Walleij <linus.walleij@linaro.org>

Commit ca53c5f1ca5c936777caca46b7c716a40682ce83 made pins loose
their identity and only get autogenerated names.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 8fe15cf..894cd5e 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -189,7 +189,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev,
 	pindesc->pctldev = pctldev;
 
 	/* Copy basic pin info */
-	if (pindesc->name) {
+	if (name) {
 		pindesc->name = name;
 	} else {
 		pindesc->name = kasprintf(GFP_KERNEL, "PIN%u", number);
-- 
1.7.8


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] pinctrl: restore pin naming
  2012-02-01 17:15 [PATCH] pinctrl: restore pin naming Linus Walleij
@ 2012-02-01 17:33 ` Stephen Warren
  2012-02-01 19:18 ` Sergei Shtylyov
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2012-02-01 17:33 UTC (permalink / raw)
  To: Linus Walleij, linux-kernel, linux-arm-kernel
  Cc: Grant Likely, Barry Song, Shawn Guo, Thomas Abraham,
	Dong Aisheng, Rajendra Nayak, Haojian Zhuang, Linus Walleij

Linus Walleij wrote at Wednesday, February 01, 2012 10:16 AM:
> Commit ca53c5f1ca5c936777caca46b7c716a40682ce83 made pins loose
> their identity and only get autogenerated names.

It might be nice to include that commit's subject for easy reference.
"Commit 234723... ("foo") made ..."

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Stephen Warren <swarren@nvidia.com>

-- 
nvpublic


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: restore pin naming
  2012-02-01 17:15 [PATCH] pinctrl: restore pin naming Linus Walleij
  2012-02-01 17:33 ` Stephen Warren
@ 2012-02-01 19:18 ` Sergei Shtylyov
  1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2012-02-01 19:18 UTC (permalink / raw)
  To: Linus Walleij
  Cc: linux-kernel, linux-arm-kernel, Stephen Warren, Linus Walleij,
	Barry Song, Haojian Zhuang, Grant Likely, Thomas Abraham,
	Rajendra Nayak, Dong Aisheng, Shawn Guo

Hello.

On 02/01/2012 08:15 PM, Linus Walleij wrote:

> From: Linus Walleij<linus.walleij@linaro.org>

> Commit ca53c5f1ca5c936777caca46b7c716a40682ce83

    Please add that commit's summary in parens.

  made pins loose

    s/loose/lose/?

> their identity and only get autogenerated names.

> Signed-off-by: Linus Walleij<linus.walleij@linaro.org>

WBR, Sergei

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-01 18:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-01 17:15 [PATCH] pinctrl: restore pin naming Linus Walleij
2012-02-01 17:33 ` Stephen Warren
2012-02-01 19:18 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).