* [Patch] tty: fix a build failure on sparc
@ 2012-02-03 5:22 Cong Wang
2012-02-03 15:53 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Cong Wang @ 2012-02-03 5:22 UTC (permalink / raw)
To: linux-kernel
Cc: Andrew Morton, Paul Gortmaker, Greg Kroah-Hartman, WANG Cong,
Alan Cox, Jamie Iles, Stephen Warren, linux-serial
On sparc, there is a build failure:
drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
(serial: group all the 8250 related code together) moved these files
into 8250/ subdirectory, but forgot to change the reference
to drivers/tty/serial/suncore.h.
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
index 9f50c4e..9b7336f 100644
--- a/drivers/tty/serial/8250/8250.c
+++ b/drivers/tty/serial/8250/8250.c
@@ -45,7 +45,7 @@
#include "8250.h"
#ifdef CONFIG_SPARC
-#include "suncore.h"
+#include "../suncore.h"
#endif
/*
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Patch] tty: fix a build failure on sparc
2012-02-03 5:22 [Patch] tty: fix a build failure on sparc Cong Wang
@ 2012-02-03 15:53 ` Greg KH
2012-02-03 16:06 ` Paul Gortmaker
2012-02-03 19:46 ` Paul Gortmaker
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2012-02-03 15:53 UTC (permalink / raw)
To: Cong Wang
Cc: linux-kernel, Andrew Morton, Paul Gortmaker, Alan Cox,
Jamie Iles, Stephen Warren, linux-serial
On Fri, Feb 03, 2012 at 01:22:10PM +0800, Cong Wang wrote:
> On sparc, there is a build failure:
>
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
>
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.
Ah, thanks, I'll go queue this up, sorry for the problem.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] tty: fix a build failure on sparc
2012-02-03 5:22 [Patch] tty: fix a build failure on sparc Cong Wang
2012-02-03 15:53 ` Greg KH
@ 2012-02-03 16:06 ` Paul Gortmaker
2012-02-03 19:46 ` Paul Gortmaker
2 siblings, 0 replies; 4+ messages in thread
From: Paul Gortmaker @ 2012-02-03 16:06 UTC (permalink / raw)
To: Cong Wang
Cc: linux-kernel, Andrew Morton, Greg Kroah-Hartman, Alan Cox,
Jamie Iles, Stephen Warren, linux-serial
On 12-02-03 12:22 AM, Cong Wang wrote:
> On sparc, there is a build failure:
>
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
>
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.
Thanks, I explicitly left sunsu out of the move but missed
that 8250 was sourcing its related header. I did defconfig
builds, but in going back to check, I see that neither sparc
32/64 defconfig enable 8250 by default, so those builds didn't
help me much at all... :(
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index 9f50c4e..9b7336f 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -45,7 +45,7 @@
> #include "8250.h"
>
> #ifdef CONFIG_SPARC
> -#include "suncore.h"
> +#include "../suncore.h"
> #endif
>
> /*
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] tty: fix a build failure on sparc
2012-02-03 5:22 [Patch] tty: fix a build failure on sparc Cong Wang
2012-02-03 15:53 ` Greg KH
2012-02-03 16:06 ` Paul Gortmaker
@ 2012-02-03 19:46 ` Paul Gortmaker
2 siblings, 0 replies; 4+ messages in thread
From: Paul Gortmaker @ 2012-02-03 19:46 UTC (permalink / raw)
To: Cong Wang
Cc: linux-kernel, Andrew Morton, Greg Kroah-Hartman, Alan Cox,
Jamie Iles, Stephen Warren, linux-serial
[Resending with updated address for Greg]
On 12-02-03 12:22 AM, Cong Wang wrote:
> On sparc, there is a build failure:
>
> drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory
> drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors'
> drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors'
>
> this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b
> (serial: group all the 8250 related code together) moved these files
> into 8250/ subdirectory, but forgot to change the reference
> to drivers/tty/serial/suncore.h.
Thanks, I explicitly left sunsu out of the move but missed
that 8250 was sourcing its related header. I did defconfig
builds, but in going back to check, I see that neither sparc
32/64 defconfig enable 8250 by default, so those builds didn't
help me much at all... :(
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index 9f50c4e..9b7336f 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -45,7 +45,7 @@
> #include "8250.h"
>
> #ifdef CONFIG_SPARC
> -#include "suncore.h"
> +#include "../suncore.h"
> #endif
>
> /*
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-03 20:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-03 5:22 [Patch] tty: fix a build failure on sparc Cong Wang
2012-02-03 15:53 ` Greg KH
2012-02-03 16:06 ` Paul Gortmaker
2012-02-03 19:46 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).