* [PATCH] bsg: fix sysfs link remove warning
@ 2012-02-08 17:23 Stanislaw Gruszka
2012-02-08 19:04 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Stanislaw Gruszka @ 2012-02-08 17:23 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
We create "bsg" link if q->kobj.sd is not NULL, so remove it only
when the same condition is true.
Fixes:
WARNING: at fs/sysfs/inode.c:323 sysfs_hash_and_remove+0x2b/0x77()
sysfs: can not remove 'bsg', no directory
Call Trace:
[<c0429683>] warn_slowpath_common+0x6a/0x7f
[<c0537a68>] ? sysfs_hash_and_remove+0x2b/0x77
[<c042970b>] warn_slowpath_fmt+0x2b/0x2f
[<c0537a68>] sysfs_hash_and_remove+0x2b/0x77
[<c053969a>] sysfs_remove_link+0x20/0x23
[<c05d88f1>] bsg_unregister_queue+0x40/0x6d
[<c0692263>] __scsi_remove_device+0x31/0x9d
[<c069149f>] scsi_forget_host+0x41/0x52
[<c0689fa9>] scsi_remove_host+0x71/0xe0
[<f7de5945>] quiesce_and_remove_host+0x51/0x83 [usb_storage]
[<f7de5a1e>] usb_stor_disconnect+0x18/0x22 [usb_storage]
[<c06c29de>] usb_unbind_interface+0x4e/0x109
[<c067a80f>] __device_release_driver+0x6b/0xa6
[<c067a861>] device_release_driver+0x17/0x22
[<c067a46a>] bus_remove_device+0xd6/0xe6
[<c06785e2>] device_del+0xf2/0x137
[<c06c101f>] usb_disable_device+0x94/0x1a0
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
block/bsg.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index 4cf703f..ff64ae3 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -983,7 +983,8 @@ void bsg_unregister_queue(struct request_queue *q)
mutex_lock(&bsg_mutex);
idr_remove(&bsg_minor_idr, bcd->minor);
- sysfs_remove_link(&q->kobj, "bsg");
+ if (q->kobj.sd)
+ sysfs_remove_link(&q->kobj, "bsg");
device_unregister(bcd->class_dev);
bcd->class_dev = NULL;
kref_put(&bcd->ref, bsg_kref_release_function);
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bsg: fix sysfs link remove warning
2012-02-08 17:23 [PATCH] bsg: fix sysfs link remove warning Stanislaw Gruszka
@ 2012-02-08 19:04 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2012-02-08 19:04 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: linux-kernel
On 02/08/2012 06:23 PM, Stanislaw Gruszka wrote:
> We create "bsg" link if q->kobj.sd is not NULL, so remove it only
> when the same condition is true.
>
> Fixes:
>
> WARNING: at fs/sysfs/inode.c:323 sysfs_hash_and_remove+0x2b/0x77()
> sysfs: can not remove 'bsg', no directory
> Call Trace:
> [<c0429683>] warn_slowpath_common+0x6a/0x7f
> [<c0537a68>] ? sysfs_hash_and_remove+0x2b/0x77
> [<c042970b>] warn_slowpath_fmt+0x2b/0x2f
> [<c0537a68>] sysfs_hash_and_remove+0x2b/0x77
> [<c053969a>] sysfs_remove_link+0x20/0x23
> [<c05d88f1>] bsg_unregister_queue+0x40/0x6d
> [<c0692263>] __scsi_remove_device+0x31/0x9d
> [<c069149f>] scsi_forget_host+0x41/0x52
> [<c0689fa9>] scsi_remove_host+0x71/0xe0
> [<f7de5945>] quiesce_and_remove_host+0x51/0x83 [usb_storage]
> [<f7de5a1e>] usb_stor_disconnect+0x18/0x22 [usb_storage]
> [<c06c29de>] usb_unbind_interface+0x4e/0x109
> [<c067a80f>] __device_release_driver+0x6b/0xa6
> [<c067a861>] device_release_driver+0x17/0x22
> [<c067a46a>] bus_remove_device+0xd6/0xe6
> [<c06785e2>] device_del+0xf2/0x137
> [<c06c101f>] usb_disable_device+0x94/0x1a0
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-08 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-08 17:23 [PATCH] bsg: fix sysfs link remove warning Stanislaw Gruszka
2012-02-08 19:04 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).