[PATCH] kdb: Avoid using dbg_io_ops until it is initialized

* [PATCH] kdb:  Avoid using dbg_io_ops until it is initialized
@ 2011-09-21 20:19 Tim Bird
  2011-09-22  2:52 ` [Kgdb-bugreport] " Dongdong Deng
  2012-03-20 18:42 ` Jason Wessel
  0 siblings, 2 replies; 5+ messages in thread
From: Tim Bird @ 2011-09-21 20:19 UTC (permalink / raw)
  To: Jason Wessel; +Cc: kgdb-bugreport, linux kernel

This fixes a bug with setting a breakpoint during kdb initialization
(from kdb_cmds).  Any call to kdb_printf() before the initialization
of the kgdboc serial console driver (which happens much later during
bootup than kdb_init), results in kernel panic due to the use of
dbg_io_ops before it is initialized.

Signed-off-by: Tim Bird <tim.bird@am.sony.com>
---
 kernel/debug/kdb/kdb_io.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index c9b7f4f..3bc995f 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -675,7 +675,7 @@ kdb_printit:
 	if (!dbg_kdb_mode && kgdb_connected) {
 		gdbstub_msg_write(kdb_buffer, retlen);
 	} else {
-		if (!dbg_io_ops->is_console) {
+		if (dbg_io_ops && !dbg_io_ops->is_console) {
 			len = strlen(kdb_buffer);
 			cp = kdb_buffer;
 			while (len--) {
-- 
1.7.2.3



^ permalink raw reply related	[flat|nested] 5+ messages in thread