* [PATCH] xen/pcifront: avoid pci_frontend_enable_msix() falsely returning success
@ 2012-04-02 14:22 Jan Beulich
0 siblings, 0 replies; only message in thread
From: Jan Beulich @ 2012-04-02 14:22 UTC (permalink / raw)
To: Jeremy Fitzhardinge, Konrad Rzeszutek Wilk; +Cc: xen-devel, linux-kernel
The original XenoLinux code has always had things this way, and for
compatibility reasons (in particular with a subsequent pciback
adjustment) upstream Linux should behave the same way (allowing for two
distinct error indications to be returned by the backend).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/pci/xen-pcifront.c | 1 +
1 file changed, 1 insertion(+)
--- 3.4-rc1/drivers/pci/xen-pcifront.c
+++ 3.4-rc1-xen-pcifront-enable-msix-retval/drivers/pci/xen-pcifront.c
@@ -290,6 +290,7 @@ static int pci_frontend_enable_msix(stru
} else {
printk(KERN_DEBUG "enable msix get value %x\n",
op.value);
+ err = op.value;
}
} else {
dev_err(&dev->dev, "enable msix get err %x\n", err);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-04-02 14:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-02 14:22 [PATCH] xen/pcifront: avoid pci_frontend_enable_msix() falsely returning success Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).