* [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64
@ 2019-03-07 16:18 Tomohiro Mayama
2019-03-09 2:52 ` Katsuhiro Suzuki
2019-03-09 16:10 ` [PATCH v2] " Tomohiro Mayama
0 siblings, 2 replies; 5+ messages in thread
From: Tomohiro Mayama @ 2019-03-07 16:18 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel
This patch makes USB ports functioning again.
Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 21107d0f4378..7f365e448867 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -45,8 +45,7 @@
vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
compatible = "regulator-fixed";
- enable-active-high;
- gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&usb20_host_drv>;
regulator-name = "vcc_host1_5v";
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64
2019-03-07 16:18 [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64 Tomohiro Mayama
@ 2019-03-09 2:52 ` Katsuhiro Suzuki
2019-03-09 15:16 ` Tomohiro Mayama
2019-03-09 16:10 ` [PATCH v2] " Tomohiro Mayama
1 sibling, 1 reply; 5+ messages in thread
From: Katsuhiro Suzuki @ 2019-03-09 2:52 UTC (permalink / raw)
To: Tomohiro Mayama, heiko; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel
Hello Mayama-san,
On 2019/03/08 1:18, Tomohiro Mayama wrote:
> This patch makes USB ports functioning again.
>
> Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 21107d0f4378..7f365e448867 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -45,8 +45,7 @@
>
> vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
> compatible = "regulator-fixed";
> - enable-active-high;
> - gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> + gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&usb20_host_drv>;
> regulator-name = "vcc_host1_5v";
>
After this patch applied, USB and S/PDIF both work well.
Tested-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
$ lsusb
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: ID 046d:c526 Logitech, Inc. Nano Receiver
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Best Regards,
Katsuhiro Suzuki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64
2019-03-09 2:52 ` Katsuhiro Suzuki
@ 2019-03-09 15:16 ` Tomohiro Mayama
0 siblings, 0 replies; 5+ messages in thread
From: Tomohiro Mayama @ 2019-03-09 15:16 UTC (permalink / raw)
To: katsuhiro, heiko; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel
On 2019/03/09 11:52, Katsuhiro Suzuki wrote:
> Hello Mayama-san,
>
> On 2019/03/08 1:18, Tomohiro Mayama wrote:
>> This patch makes USB ports functioning again.
>>
>> Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> index 21107d0f4378..7f365e448867 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
>> @@ -45,8 +45,7 @@
>> vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
>> compatible = "regulator-fixed";
>> - enable-active-high;
>> - gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
>> + gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&usb20_host_drv>;
>> regulator-name = "vcc_host1_5v";
>>
>
> After this patch applied, USB and S/PDIF both work well.
>
> Tested-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>
>
> $ lsusb
> Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
> Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> Bus 001 Device 002: ID 046d:c526 Logitech, Inc. Nano Receiver
> Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
>
>
> Best Regards,
> Katsuhiro Suzuki
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
Thank you for testing my patch, Suzuki-san!
Regards,
Tomohiro Mayama
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64
2019-03-07 16:18 [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64 Tomohiro Mayama
2019-03-09 2:52 ` Katsuhiro Suzuki
@ 2019-03-09 16:10 ` Tomohiro Mayama
2019-03-12 10:08 ` Heiko Stuebner
1 sibling, 1 reply; 5+ messages in thread
From: Tomohiro Mayama @ 2019-03-09 16:10 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel
This patch makes USB ports functioning again.
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
Tested-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
v2:
* Added Suggested-by and Tested-by tags
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 21107d0f4378..7f365e448867 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -45,8 +45,7 @@
vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
compatible = "regulator-fixed";
- enable-active-high;
- gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&usb20_host_drv>;
regulator-name = "vcc_host1_5v";
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64
2019-03-09 16:10 ` [PATCH v2] " Tomohiro Mayama
@ 2019-03-12 10:08 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2019-03-12 10:08 UTC (permalink / raw)
To: Tomohiro Mayama; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel
Am Samstag, 9. März 2019, 17:10:12 CET schrieb Tomohiro Mayama:
> This patch makes USB ports functioning again.
>
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
> Tested-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
added Fixes and Cc-stable tags and applied as fix for 5.1
Thanks
Heiko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-12 10:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 16:18 [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on rk3328-rock64 Tomohiro Mayama
2019-03-09 2:52 ` Katsuhiro Suzuki
2019-03-09 15:16 ` Tomohiro Mayama
2019-03-09 16:10 ` [PATCH v2] " Tomohiro Mayama
2019-03-12 10:08 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).