From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@kernel.org,
vincent.guittot@linaro.org, morten.rasmussen@arm.com,
mgorman@techsingularity.net
Subject: Re: [PATCH] sched/topology: Fix overlapping sched_group build
Date: Wed, 25 Mar 2020 12:05:52 +0100 [thread overview]
Message-ID: <4aa814d5-abcd-23b3-323c-5a3503ae3d0a@arm.com> (raw)
In-Reply-To: <jhjmu85sm8b.mognet@arm.com>
On 24.03.20 18:20, Valentin Schneider wrote:
>
> On Tue, Mar 24 2020, Valentin Schneider wrote:
>> Fix
>> ===
>>
>> Sanitize the groups we get out of build_group_from_child_sched_domain()
>> with the span of the domain we're currently building - this ensures the
>> groups we build only contain CPUs that are the right distance away from the
>> base CPU. This also requires modifying build_balance_mask().
>>
>
> I somehow missed that this triggers the WARN_ON_ONCE() in
> init_overlap_sched_group(). Gotta figure out why.
Cool, seems like qemu can emulate this!
qemu-system-aarch64 -kernel Image -hda ./qemu-image-aarch64.img -append
'root=/dev/vda console=ttyAMA0 loglevel=8 sched_debug' -smp cores=8
--nographic -m 512 -cpu cortex-a53 -machine virt -numa
node,cpus=0-1,nodeid=0 -numa node,cpus=2-3,nodeid=1, -numa
node,cpus=4-5,nodeid=2, -numa node,cpus=6-7,nodeid=3, -numa
dist,src=0,dst=1,val=12, -numa dist,src=0,dst=2,val=20, -numa
dist,src=0,dst=3,val=22, -numa dist,src=1,dst=2,val=22, -numa
dist,src=1,dst=3,val=24, -numa dist,src=2,dst=3,val=12
...
[ 0.711685]
[ 0.711767] 10 12 20 22
[ 0.711860] 12 10 22 24
[ 0.711917] 20 22 10 12
[ 0.711970] 22 24 12 10
[ 0.712036]
[ 0.718356] CPU0 attaching sched-domain(s):
[ 0.718433] domain-0: span=0-1 level=MC
[ 0.718646] groups: 0:{ span=0 cap=1006 }, 1:{ span=1 cap=1015 }
[ 0.718865] domain-1: span=0-3 level=NUMA
[ 0.718906] groups: 0:{ span=0-1 cap=2021 }, 2:{ span=2-3 cap=2014 }
[ 0.719044] domain-2: span=0-5 level=NUMA
[ 0.719082] groups: 0:{ span=0-3 cap=4035 }, 4:{ span=4-7 cap=3855 }
[ 0.719164] ERROR: groups don't span domain->span
[ 0.719191] domain-3: span=0-7 level=NUMA
[ 0.719228] groups: 0:{ span=0-5 mask=0-1 cap=5974 }, 6:{
span=4-7 mask=6-7 cap=3964 }
[ 0.719961] CPU1 attaching sched-domain(s):
...
cat /proc/sys/kernel/sched_domain/cpu0/domain*/{name,flags}
MC
NUMA
NUMA
NUMA
4655
25647
25647
25647
next prev parent reply other threads:[~2020-03-25 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 12:55 [PATCH] sched/topology: Fix overlapping sched_group build Valentin Schneider
2020-03-24 17:20 ` Valentin Schneider
2020-03-25 11:05 ` Dietmar Eggemann [this message]
2020-03-25 11:22 ` Valentin Schneider
2020-03-25 17:53 ` Valentin Schneider
2020-03-25 18:09 ` Valentin Schneider
2020-03-25 18:38 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aa814d5-abcd-23b3-323c-5a3503ae3d0a@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).