* [PATCH] block: loop: constify attribute_group structures.
@ 2017-07-03 7:23 Arvind Yadav
0 siblings, 0 replies; only message in thread
From: Arvind Yadav @ 2017-07-03 7:23 UTC (permalink / raw)
To: akpm, hare, dhowells; +Cc: linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
15816 865 88 16769 4181 drivers/block/loop.o
File size After adding 'const':
text data bss dec hex filename
15880 801 88 16769 4181 drivers/block/loop.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 28d9329..2e413d5 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -788,7 +788,7 @@ static ssize_t loop_attr_dio_show(struct loop_device *lo, char *buf)
NULL,
};
-static struct attribute_group loop_attribute_group = {
+static const struct attribute_group loop_attribute_group = {
.name = "loop",
.attrs= loop_attrs,
};
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-03 7:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-03 7:23 [PATCH] block: loop: constify attribute_group structures Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).