* [PATCH] um: remove unused variable
@ 2019-03-12 13:30 Bartosz Golaszewski
2019-03-13 9:48 ` Anton Ivanov
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-03-12 13:30 UTC (permalink / raw)
To: Jeff Dike, Richard Weinberger, Anton Ivanov
Cc: linux-um, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
The buf variable is unused. Remove it.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/um/kernel/skas/uaccess.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/um/kernel/skas/uaccess.c b/arch/um/kernel/skas/uaccess.c
index 7f06fdbc7ee1..bd3cb694322c 100644
--- a/arch/um/kernel/skas/uaccess.c
+++ b/arch/um/kernel/skas/uaccess.c
@@ -59,7 +59,6 @@ static pte_t *maybe_map(unsigned long virt, int is_write)
static int do_op_one_page(unsigned long addr, int len, int is_write,
int (*op)(unsigned long addr, int len, void *arg), void *arg)
{
- jmp_buf buf;
struct page *page;
pte_t *pte;
int n;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] um: remove unused variable
2019-03-12 13:30 [PATCH] um: remove unused variable Bartosz Golaszewski
@ 2019-03-13 9:48 ` Anton Ivanov
0 siblings, 0 replies; 3+ messages in thread
From: Anton Ivanov @ 2019-03-13 9:48 UTC (permalink / raw)
To: Bartosz Golaszewski, Jeff Dike, Richard Weinberger
Cc: Bartosz Golaszewski, linux-um, linux-kernel
On 12/03/2019 13:30, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The buf variable is unused. Remove it.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/um/kernel/skas/uaccess.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/um/kernel/skas/uaccess.c b/arch/um/kernel/skas/uaccess.c
> index 7f06fdbc7ee1..bd3cb694322c 100644
> --- a/arch/um/kernel/skas/uaccess.c
> +++ b/arch/um/kernel/skas/uaccess.c
> @@ -59,7 +59,6 @@ static pte_t *maybe_map(unsigned long virt, int is_write)
> static int do_op_one_page(unsigned long addr, int len, int is_write,
> int (*op)(unsigned long addr, int len, void *arg), void *arg)
> {
> - jmp_buf buf;
> struct page *page;
> pte_t *pte;
> int n;
>
Reviewed-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] um: remove unused variable
@ 2022-06-01 7:46 Haowen Bai
0 siblings, 0 replies; 3+ messages in thread
From: Haowen Bai @ 2022-06-01 7:46 UTC (permalink / raw)
To: Richard Weinberger, Anton Ivanov, Johannes Berg
Cc: Haowen Bai, linux-um, linux-kernel
The variable dead is initialized but never used otherwise.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
arch/um/os-Linux/umid.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/um/os-Linux/umid.c b/arch/um/os-Linux/umid.c
index a3dd61521d24..7a1abb829930 100644
--- a/arch/um/os-Linux/umid.c
+++ b/arch/um/os-Linux/umid.c
@@ -136,7 +136,7 @@ static int remove_files_and_dir(char *dir)
static inline int is_umdir_used(char *dir)
{
char pid[sizeof("nnnnnnnnn")], *end, *file;
- int dead, fd, p, n, err;
+ int fd, p, n, err;
size_t filelen = strlen(dir) + sizeof("/pid") + 1;
file = malloc(filelen);
@@ -145,7 +145,6 @@ static inline int is_umdir_used(char *dir)
snprintf(file, filelen, "%s/pid", dir);
- dead = 0;
fd = open(file, O_RDONLY);
if (fd < 0) {
fd = -errno;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-01 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 13:30 [PATCH] um: remove unused variable Bartosz Golaszewski
2019-03-13 9:48 ` Anton Ivanov
2022-06-01 7:46 Haowen Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).