From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, kernel-janitors@vger.kernel.org
Cc: Enrico Weigelt <lkml@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: drivers: Inline code in devm_platform_ioremap_resource() from two functions
Date: Sat, 15 Jun 2019 13:00:17 +0200 [thread overview]
Message-ID: <4b4b2d76-7af5-5466-16ea-aad0825578a0@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1906141127030.9068@hadrien>
>> Two function calls were combined in this function implementation.
>> Inline corresponding code so that extra error checks can be avoided here.
>
> I don't see any point to this at all.
Would you like to take another look at corresponding design options?
How do you think about to check run time characteristics any more?
> By inlining the code, you have created a clone,
> which will introduce extra work to maintain in the future.
Would you find the shown software transformation acceptable
if a C compiler will be able to generate a similar code structure?
Regards,
Markus
next prev parent reply other threads:[~2019-06-15 11:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 6:11 [PATCH] coccinelle: api: add devm_platform_ioremap_resource script Himanshu Jha
2019-04-06 6:31 ` Julia Lawall
2019-04-06 6:34 ` Julia Lawall
2019-07-06 12:16 ` [Cocci] " Masahiro Yamada
2019-07-06 13:39 ` Julia Lawall
2019-07-07 9:55 ` Coccinelle: " Markus Elfring
2019-07-07 12:38 ` Masahiro Yamada
2019-09-19 7:21 ` Markus Elfring
2019-04-06 12:36 ` [PATCH] coccinelle: " Markus Elfring
2019-06-08 15:24 ` Coccinelle: " Markus Elfring
2019-06-08 17:26 ` Julia Lawall
2019-06-09 8:55 ` Markus Elfring
2019-06-11 20:40 ` Enrico Weigelt, metux IT consult
2019-06-12 5:28 ` Julia Lawall
2019-06-12 6:24 ` Markus Elfring
2019-06-14 9:22 ` [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions Markus Elfring
2019-06-14 9:27 ` [Cocci] " Julia Lawall
2019-06-15 11:00 ` Markus Elfring [this message]
2019-06-14 10:07 ` Greg Kroah-Hartman
2019-06-17 20:21 ` Enrico Weigelt, metux IT consult
2019-06-18 5:37 ` Markus Elfring
2019-06-18 9:35 ` Enrico Weigelt, metux IT consult
2019-06-18 10:21 ` Dan Carpenter
2019-06-18 11:44 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4b2d76-7af5-5466-16ea-aad0825578a0@web.de \
--to=markus.elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).