From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Markus Elfring <Markus.Elfring@web.de>,
Julia Lawall <julia.lawall@lip6.fr>,
Himanshu Jha <himanshujha199640@gmail.com>
Cc: cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: Coccinelle: api: add devm_platform_ioremap_resource script
Date: Tue, 11 Jun 2019 22:40:25 +0200 [thread overview]
Message-ID: <f573b2d3-11d0-92b5-f8ab-4c4b6493e152@metux.net> (raw)
In-Reply-To: <7b4fe770-dadd-80ba-2ba4-0f2bc90984ef@web.de>
On 09.06.19 10:55, Markus Elfring wrote:
<snip>
>> But there is not usually any interesting formatting on the left side of an
>> assignment (ie typically no newlines or comments).
>
> Is there any need to trigger additional source code reformatting?
>
>> I can see no purpose to factorizing the right parenthesis.
>
> These characters at the end of such a function call should be kept unchanged.
Agreed. OTOH, we all know that spatch results still need to be carefully
checked. I suspect trying to teach it all the formatting rules of the
kernel isn't an easy task.
> The flag “IORESOURCE_MEM” is passed as the second parameter for the call
> of the function “platform_get_resource” in this refactoring.
In that particular case, we maybe should consider separate inline
helpers instead of passing this is a parameter.
Maybe it would even be more efficient to have completely separate
versions of devm_platform_ioremap_resource(), so we don't even have
to pass that parameter on stack.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-06-11 20:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 6:11 [PATCH] coccinelle: api: add devm_platform_ioremap_resource script Himanshu Jha
2019-04-06 6:31 ` Julia Lawall
2019-04-06 6:34 ` Julia Lawall
2019-07-06 12:16 ` [Cocci] " Masahiro Yamada
2019-07-06 13:39 ` Julia Lawall
2019-07-07 9:55 ` Coccinelle: " Markus Elfring
2019-07-07 12:38 ` Masahiro Yamada
2019-09-19 7:21 ` Markus Elfring
2019-04-06 12:36 ` [PATCH] coccinelle: " Markus Elfring
2019-06-08 15:24 ` Coccinelle: " Markus Elfring
2019-06-08 17:26 ` Julia Lawall
2019-06-09 8:55 ` Markus Elfring
2019-06-11 20:40 ` Enrico Weigelt, metux IT consult [this message]
2019-06-12 5:28 ` Julia Lawall
2019-06-12 6:24 ` Markus Elfring
2019-06-14 9:22 ` [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions Markus Elfring
2019-06-14 9:27 ` [Cocci] " Julia Lawall
2019-06-15 11:00 ` Markus Elfring
2019-06-14 10:07 ` [PATCH] " Greg Kroah-Hartman
2019-06-17 20:21 ` Enrico Weigelt, metux IT consult
2019-06-18 5:37 ` Markus Elfring
2019-06-18 9:35 ` Enrico Weigelt, metux IT consult
2019-06-18 10:21 ` Dan Carpenter
2019-06-18 11:44 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f573b2d3-11d0-92b5-f8ab-4c4b6493e152@metux.net \
--to=lkml@metux.net \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).