* [PATCH] ata: macio: Use of_node_name_eq for node name comparisons @ 2018-12-05 19:50 ` Rob Herring 2019-02-07 12:02 ` Bartlomiej Zolnierkiewicz 2019-02-08 13:45 ` Jens Axboe 0 siblings, 2 replies; 3+ messages in thread From: Rob Herring @ 2018-12-05 19:50 UTC (permalink / raw) To: devicetree, linux-kernel; +Cc: Bartlomiej Zolnierkiewicz, Jens Axboe, linux-ide Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: linux-ide@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/ata/pata_macio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index 9588e685d994..9e2501da4638 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -948,7 +948,7 @@ static void pata_macio_invariants(struct pata_macio_priv *priv) priv->kind = controller_k2_ata6; priv->timings = pata_macio_kauai_timings; } else if (of_device_is_compatible(priv->node, "keylargo-ata")) { - if (strcmp(priv->node->name, "ata-4") == 0) { + if (of_node_name_eq(priv->node, "ata-4")) { priv->kind = controller_kl_ata4; priv->timings = pata_macio_kl66_timings; } else { -- 2.19.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: macio: Use of_node_name_eq for node name comparisons 2018-12-05 19:50 ` [PATCH] ata: macio: Use of_node_name_eq for node name comparisons Rob Herring @ 2019-02-07 12:02 ` Bartlomiej Zolnierkiewicz 2019-02-08 13:45 ` Jens Axboe 1 sibling, 0 replies; 3+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-02-07 12:02 UTC (permalink / raw) To: Rob Herring; +Cc: devicetree, linux-kernel, Jens Axboe, linux-ide On 12/05/2018 08:50 PM, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Jens Axboe <axboe@kernel.dk> > Cc: linux-ide@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: macio: Use of_node_name_eq for node name comparisons 2018-12-05 19:50 ` [PATCH] ata: macio: Use of_node_name_eq for node name comparisons Rob Herring 2019-02-07 12:02 ` Bartlomiej Zolnierkiewicz @ 2019-02-08 13:45 ` Jens Axboe 1 sibling, 0 replies; 3+ messages in thread From: Jens Axboe @ 2019-02-08 13:45 UTC (permalink / raw) To: Rob Herring, devicetree, linux-kernel Cc: Bartlomiej Zolnierkiewicz, linux-ide On 12/5/18 12:50 PM, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. Applied, thanks. -- Jens Axboe ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-08 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20181205195131epcas3p3519c2452d1c90583338f098540e721ee@epcas3p3.samsung.com>
2018-12-05 19:50 ` [PATCH] ata: macio: Use of_node_name_eq for node name comparisons Rob Herring
2019-02-07 12:02 ` Bartlomiej Zolnierkiewicz
2019-02-08 13:45 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).