* [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
@ 2023-08-03 2:59 Randy Dunlap
2023-08-03 11:27 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-08-03 2:59 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Grant Likely, Mark Brown, Liam Girdwood,
Shengjiu Wang, Xiubo Li, alsa-devel, linuxppc-dev,
Jaroslav Kysela, Takashi Iwai
Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
so the 2 former symbols should also depend on PPC_BESTCOMM since
"select" does not follow any dependency chains.
This prevents a kconfig warning and build errors:
WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
- SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>
Cc: alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
---
v2: use correct email address for Mark Brown.
sound/soc/fsl/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
config SND_MPC52xx_SOC_PCM030
tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
- depends on PPC_MPC5200_SIMPLE
+ depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
select SND_SOC_MPC5200_AC97
select SND_SOC_WM9712
help
@@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
config SND_MPC52xx_SOC_EFIKA
tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
- depends on PPC_EFIKA
+ depends on PPC_EFIKA && PPC_BESTCOMM
select SND_SOC_MPC5200_AC97
select SND_SOC_STAC9766
help
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
2023-08-03 2:59 [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Randy Dunlap
@ 2023-08-03 11:27 ` Mark Brown
2023-08-03 18:09 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2023-08-03 11:27 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Grant Likely, Liam Girdwood, Shengjiu Wang,
Xiubo Li, alsa-devel, linuxppc-dev, Jaroslav Kysela,
Takashi Iwai
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Wed, Aug 02, 2023 at 07:59:41PM -0700, Randy Dunlap wrote:
> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
> so the 2 former symbols should also depend on PPC_BESTCOMM since
> "select" does not follow any dependency chains.
Take a hint, it's not clear that the patch is tasteful.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
2023-08-03 11:27 ` Mark Brown
@ 2023-08-03 18:09 ` Randy Dunlap
2023-08-03 18:22 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-08-03 18:09 UTC (permalink / raw)
To: Mark Brown
Cc: linux-kernel, Grant Likely, Liam Girdwood, Shengjiu Wang,
Xiubo Li, alsa-devel, linuxppc-dev, Jaroslav Kysela,
Takashi Iwai
On 8/3/23 04:27, Mark Brown wrote:
> On Wed, Aug 02, 2023 at 07:59:41PM -0700, Randy Dunlap wrote:
>> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
>> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
>> so the 2 former symbols should also depend on PPC_BESTCOMM since
>> "select" does not follow any dependency chains.
>
> Take a hint, it's not clear that the patch is tasteful.
Thank you for replying. I'll drop it and just report the build errors.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
2023-08-03 18:09 ` Randy Dunlap
@ 2023-08-03 18:22 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2023-08-03 18:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Grant Likely, Liam Girdwood, Shengjiu Wang,
Xiubo Li, alsa-devel, linuxppc-dev, Jaroslav Kysela,
Takashi Iwai
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Thu, Aug 03, 2023 at 11:09:43AM -0700, Randy Dunlap wrote:
> On 8/3/23 04:27, Mark Brown wrote:
> > On Wed, Aug 02, 2023 at 07:59:41PM -0700, Randy Dunlap wrote:
> >> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
> >> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
> >> so the 2 former symbols should also depend on PPC_BESTCOMM since
> >> "select" does not follow any dependency chains.
> > Take a hint, it's not clear that the patch is tasteful.
> Thank you for replying. I'll drop it and just report the build errors.
To be clear I generally don't give you review comments because in the
past I grew so frustrated with having them and their escalations
ignored that it seemed better to just not start. If the patch seems
fine I generally apply it, usually you just don't resend patches so that
works.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-03 18:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 2:59 [PATCH v2 RESEND*3] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Randy Dunlap
2023-08-03 11:27 ` Mark Brown
2023-08-03 18:09 ` Randy Dunlap
2023-08-03 18:22 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).