From: Philippe Schenker <philippe.schenker@toradex.com>
To: "shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "stefan@agner.ch" <stefan@agner.ch>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"michal.vokac@ysoft.com" <michal.vokac@ysoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Max Krummenacher <max.krummenacher@toradex.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Subject: Re: [PATCH v4 11/21] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces
Date: Wed, 21 Aug 2019 13:15:53 +0000 [thread overview]
Message-ID: <4c318f310babcf655be8db79abcfce547daea284.camel@toradex.com> (raw)
In-Reply-To: <20190819112754.GU5999@X250>
On Mon, 2019-08-19 at 13:27 +0200, Shawn Guo wrote:
> On Mon, Aug 12, 2019 at 02:21:31PM +0000, Philippe Schenker wrote:
> > This patch prepares the devicetree for the new Ixora V1.2 where we
> > are
> > able to turn off the supply of the can transceiver. This implies to
> > use
> > a sleep state on transmission pins in order to prevent backfeeding.
> >
> > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> > Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > Changes in v4:
> > - Add Marcel Ziswiler's Ack
> >
> > Changes in v3: None
> > Changes in v2:
> > - Changed commit title to '...imx6qdl-apalis:...'
> >
> > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 27 +++++++++++++++++++++---
> > ---
> > 1 file changed, 21 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > index 7c4ad541c3f5..59ed2e4a1fd1 100644
> > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > @@ -148,14 +148,16 @@
> > };
> >
> > &can1 {
> > - pinctrl-names = "default";
> > - pinctrl-0 = <&pinctrl_flexcan1>;
>
> This line doesn't need to be changed.
You're right, but by adding pinctrl_flexcan1_sleep here, I'd like to
emphasize between "default" and "sleep" and change that.
Since it's only used in this file I don't see any problems.
Philippe
>
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&pinctrl_flexcan1_default>;
> > + pinctrl-1 = <&pinctrl_flexcan1_sleep>;
> > status = "disabled";
> > };
> >
> > &can2 {
> > - pinctrl-names = "default";
> > - pinctrl-0 = <&pinctrl_flexcan2>;
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&pinctrl_flexcan2_default>;
> > + pinctrl-1 = <&pinctrl_flexcan2_sleep>;
> > status = "disabled";
> > };
> >
> > @@ -599,19 +601,32 @@
> > >;
> > };
> >
> > - pinctrl_flexcan1: flexcan1grp {
>
> Ditto. I take them as unnecessary changes.
>
> Shawn
>
> > + pinctrl_flexcan1_default: flexcan1defgrp {
> > fsl,pins = <
> > MX6QDL_PAD_GPIO_7__FLEXCAN1_TX 0x1b0b0
> > MX6QDL_PAD_GPIO_8__FLEXCAN1_RX 0x1b0b0
> > >;
> > };
> >
> > - pinctrl_flexcan2: flexcan2grp {
> > + pinctrl_flexcan1_sleep: flexcan1slpgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_GPIO_7__GPIO1_IO07 0x0
> > + MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x0
> > + >;
> > + };
> > +
> > + pinctrl_flexcan2_default: flexcan2defgrp {
> > fsl,pins = <
> > MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x1b0b0
> > MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x1b0b0
> > >;
> > };
> > + pinctrl_flexcan2_sleep: flexcan2slpgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_KEY_COL4__GPIO4_IO14 0x0
> > + MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x0
> > + >;
> > + };
> >
> > pinctrl_gpio_bl_on: gpioblon {
> > fsl,pins = <
> > --
> > 2.22.0
> >
next prev parent reply other threads:[~2019-08-21 13:16 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 14:21 [PATCH v4 00/21] Common patches from downstream development Philippe Schenker
2019-08-12 14:21 ` [PATCH v4 01/21] ARM: dts: imx7-colibri: make sure module supplies are always on Philippe Schenker
2019-08-19 10:58 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 02/21] ARM: dts: imx7-colibri: disable HS400 Philippe Schenker
2019-08-15 13:52 ` Oleksandr Suvorov
2019-08-19 11:06 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 03/21] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN Philippe Schenker
2019-08-19 11:09 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet Philippe Schenker
2019-08-19 11:12 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 05/21] ARM: dts: imx7-colibri: add recovery for I2C for iMX7 Philippe Schenker
2019-08-19 11:14 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key Philippe Schenker
2019-08-19 11:17 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support Philippe Schenker
2019-08-19 11:18 ` Shawn Guo
2019-08-21 12:49 ` Philippe Schenker
2019-08-12 14:21 ` [PATCH v4 08/21] ARM: dts: imx7-colibri: Add touch controllers Philippe Schenker
2019-08-15 10:59 ` Oleksandr Suvorov
2019-08-19 11:21 ` Shawn Guo
2019-08-21 12:51 ` Philippe Schenker
2019-08-12 14:21 ` [PATCH v4 09/21] ARM: dts: imx6qdl-colibri: add phy to fec Philippe Schenker
2019-08-19 11:22 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 10/21] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc Philippe Schenker
2019-08-19 11:25 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 11/21] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces Philippe Schenker
2019-08-19 11:27 ` Shawn Guo
2019-08-21 13:15 ` Philippe Schenker [this message]
2019-08-12 14:21 ` [PATCH v4 12/21] ARM: dts: imx6-apalis: Add touchscreens used on Toradex eval boards Philippe Schenker
2019-08-15 11:04 ` Oleksandr Suvorov
2019-08-19 11:30 ` Shawn Guo
2019-08-12 14:21 ` [PATCH v4 13/21] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board Philippe Schenker
2019-08-15 11:00 ` Oleksandr Suvorov
2019-08-12 14:21 ` [PATCH v4 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec Philippe Schenker
2019-08-16 7:09 ` Oleksandr Suvorov
2019-08-12 14:21 ` [PATCH v4 15/21] ARM: dts: imx6ull-colibri: reduce v_batt current in power off Philippe Schenker
2019-08-15 7:55 ` Oleksandr Suvorov
2019-08-12 14:21 ` [PATCH v4 16/21] ARM: dts: imx6ull-colibri: Add watchdog Philippe Schenker
2019-08-12 14:21 ` [PATCH v4 17/21] ARM: dts: imx6ull: improve can templates Philippe Schenker
2019-08-15 7:42 ` Oleksandr Suvorov
2019-08-12 14:21 ` [PATCH v4 18/21] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri Philippe Schenker
2019-08-15 13:44 ` Oleksandr Suvorov
2019-08-12 14:21 ` [PATCH v4 19/21] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board Philippe Schenker
2019-08-15 11:02 ` Oleksandr Suvorov
2019-08-12 14:21 ` [PATCH v4 20/21] ARM: dts: imx7-colibri: Add UHS support to eval board Philippe Schenker
2019-08-16 6:44 ` Philippe Schenker
2019-08-12 14:21 ` [PATCH v4 21/21] ARM: dts: imx6qdl-colibri.dtsi: UHS-I support for v1.1a hw Philippe Schenker
2019-08-16 6:44 ` Philippe Schenker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c318f310babcf655be8db79abcfce547daea284.camel@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=michal.vokac@ysoft.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).