* [PATCH] usb: usbip: remove redundant pointer ep
@ 2018-07-13 10:45 Colin King
2018-07-24 16:42 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-13 10:45 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer ep is being assigned but is never used hence it is
redundant and can be removed.
Cleans up clang warning:
warning: variable 'ep' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/usbip/vudc_dev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
index 1b9a4f87db59..1634d8698e15 100644
--- a/drivers/usb/usbip/vudc_dev.c
+++ b/drivers/usb/usbip/vudc_dev.c
@@ -279,12 +279,10 @@ static int vep_disable(struct usb_ep *_ep)
static struct usb_request *vep_alloc_request(struct usb_ep *_ep,
gfp_t mem_flags)
{
- struct vep *ep;
struct vrequest *req;
if (!_ep)
return NULL;
- ep = to_vep(_ep);
req = kzalloc(sizeof(*req), mem_flags);
if (!req)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: usbip: remove redundant pointer ep
2018-07-13 10:45 [PATCH] usb: usbip: remove redundant pointer ep Colin King
@ 2018-07-24 16:42 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2018-07-24 16:42 UTC (permalink / raw)
To: Colin King, Valentina Manea, Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel, Shuah Khan
On 07/13/2018 04:45 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ep is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'ep' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/usbip/vudc_dev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 1b9a4f87db59..1634d8698e15 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -279,12 +279,10 @@ static int vep_disable(struct usb_ep *_ep)
> static struct usb_request *vep_alloc_request(struct usb_ep *_ep,
> gfp_t mem_flags)
> {
> - struct vep *ep;
> struct vrequest *req;
>
> if (!_ep)
> return NULL;
> - ep = to_vep(_ep);
>
> req = kzalloc(sizeof(*req), mem_flags);
> if (!req)
>
Thanks for the patch. Looks good to me.
Acked-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-24 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 10:45 [PATCH] usb: usbip: remove redundant pointer ep Colin King
2018-07-24 16:42 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).