* [PATCH] staging: media: meson: vdec: Make use of the helper function devm_platform_ioremap_resource_byname()
@ 2021-09-08 10:57 Cai Huoqing
2021-09-08 12:07 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-08 10:57 UTC (permalink / raw)
To: caihuoqing
Cc: Neil Armstrong, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, linux-media,
linux-amlogic, linux-staging, linux-arm-kernel, linux-kernel
Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/staging/media/meson/vdec/vdec.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
index e51d69c4729d..8549d95be0f2 100644
--- a/drivers/staging/media/meson/vdec/vdec.c
+++ b/drivers/staging/media/meson/vdec/vdec.c
@@ -994,7 +994,6 @@ static int vdec_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct video_device *vdev;
struct amvdec_core *core;
- struct resource *r;
const struct of_device_id *of_id;
int irq;
int ret;
@@ -1006,13 +1005,11 @@ static int vdec_probe(struct platform_device *pdev)
core->dev = dev;
platform_set_drvdata(pdev, core);
- r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
- core->dos_base = devm_ioremap_resource(dev, r);
+ core->dos_base = devm_platform_ioremap_resource_byname(pdev, "dos");
if (IS_ERR(core->dos_base))
return PTR_ERR(core->dos_base);
- r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
- core->esparser_base = devm_ioremap_resource(dev, r);
+ core->esparser_base = devm_platform_ioremap_resource_byname(pdev, "esparser");
if (IS_ERR(core->esparser_base))
return PTR_ERR(core->esparser_base);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: meson: vdec: Make use of the helper function devm_platform_ioremap_resource_byname()
2021-09-08 10:57 [PATCH] staging: media: meson: vdec: Make use of the helper function devm_platform_ioremap_resource_byname() Cai Huoqing
@ 2021-09-08 12:07 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-09-08 12:07 UTC (permalink / raw)
To: Cai Huoqing
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, linux-media, linux-amlogic,
linux-staging, linux-arm-kernel, linux-kernel
On 08/09/2021 12:57, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/staging/media/meson/vdec/vdec.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> index e51d69c4729d..8549d95be0f2 100644
> --- a/drivers/staging/media/meson/vdec/vdec.c
> +++ b/drivers/staging/media/meson/vdec/vdec.c
> @@ -994,7 +994,6 @@ static int vdec_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct video_device *vdev;
> struct amvdec_core *core;
> - struct resource *r;
> const struct of_device_id *of_id;
> int irq;
> int ret;
> @@ -1006,13 +1005,11 @@ static int vdec_probe(struct platform_device *pdev)
> core->dev = dev;
> platform_set_drvdata(pdev, core);
>
> - r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
> - core->dos_base = devm_ioremap_resource(dev, r);
> + core->dos_base = devm_platform_ioremap_resource_byname(pdev, "dos");
> if (IS_ERR(core->dos_base))
> return PTR_ERR(core->dos_base);
>
> - r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
> - core->esparser_base = devm_ioremap_resource(dev, r);
> + core->esparser_base = devm_platform_ioremap_resource_byname(pdev, "esparser");
> if (IS_ERR(core->esparser_base))
> return PTR_ERR(core->esparser_base);
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-08 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 10:57 [PATCH] staging: media: meson: vdec: Make use of the helper function devm_platform_ioremap_resource_byname() Cai Huoqing
2021-09-08 12:07 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).