From: Pavel Skripkin <paskripkin@gmail.com>
To: "Clément Léger" <clement.leger@bootlin.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] net: ocelot: fix wrong time_after usage
Date: Mon, 27 Jun 2022 17:46:10 +0300 [thread overview]
Message-ID: <4d08b849-3e79-7c82-803c-51c251344c7a@gmail.com> (raw)
In-Reply-To: <20220624171429.4b3f7c0a@fixe.home>
On 6/24/22 18:14, Clément Léger wrote:
> So I actually tested and added logging to see if the CH_SAFE
> register bits are set for the channel on the first iteration. From
> what I could test (iperf3 with huge/non huge packets, TCP/UDP), it
> always return true on the first try. So since I think Pavel solution
> is ok to go with.
>
> However, since ocelot_fdma_wait_chan_safe() is also called in the napi
> poll function of this driver, I don't think sleeping is allowed (softirq
> context) and thus I would suggest using the readx_poll_timeout_atomic()
> function instead.
>
> Regarding the delay to wait between each read, I don't have any
> information about that possible value, the datasheet only says "wait
> for the bit to be set" so I guess we'll have to live with an
> approximate value.
>
Thank you for testing!
I will update update v3 with _atomic variant
Thanks,
--Pavel Skripkin
prev parent reply other threads:[~2022-06-27 14:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 20:40 [PATCH] net: ocelot: fix wront time_after usage Pavel Skripkin
2022-05-19 23:13 ` Vladimir Oltean
2022-05-20 8:21 ` Clément Léger
2022-05-20 12:40 ` Andrew Lunn
2022-05-20 21:06 ` Pavel Skripkin
2022-05-20 21:31 ` [PATCH v2] net: ocelot: fix wrong " Pavel Skripkin
2022-05-21 13:55 ` Andrew Lunn
2022-05-21 16:21 ` Vladimir Oltean
2022-05-23 14:00 ` Clément Léger
2022-05-27 3:42 ` Jakub Kicinski
2022-06-24 15:14 ` Clément Léger
2022-06-27 14:46 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d08b849-3e79-7c82-803c-51c251344c7a@gmail.com \
--to=paskripkin@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=clement.leger@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).