linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* hmm pud-entry callback locking?
@ 2019-10-05 12:29 Thomas Hellström (VMware)
  2019-10-07 14:19 ` Jerome Glisse
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Hellström (VMware) @ 2019-10-05 12:29 UTC (permalink / raw)
  To: Jerome Glisse; +Cc: linux-mm, linux-kernel, Kirill A. Shutemov

Hi, Jerome,

I was asked by Kirill to try to unify the pagewalk pud_entry and 
pmd_entry callbacks. The only user of the pagewalk pud-entry is 
currently hmm.

But the pagewalk code call pud_entry only for huge puds with the 
page-table lock held, whereas the hmm callback appears to assume it gets 
called unconditionally without the page-table lock held?

Could you shed some light into this?

Thanks,
Thomas



^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: hmm pud-entry callback locking?
  2019-10-05 12:29 hmm pud-entry callback locking? Thomas Hellström (VMware)
@ 2019-10-07 14:19 ` Jerome Glisse
  0 siblings, 0 replies; 2+ messages in thread
From: Jerome Glisse @ 2019-10-07 14:19 UTC (permalink / raw)
  To: Thomas Hellström (VMware); +Cc: linux-mm, linux-kernel, Kirill A. Shutemov

On Sat, Oct 05, 2019 at 02:29:40PM +0200, Thomas Hellström (VMware) wrote:
> Hi, Jerome,
> 
> I was asked by Kirill to try to unify the pagewalk pud_entry and pmd_entry
> callbacks. The only user of the pagewalk pud-entry is currently hmm.
> 
> But the pagewalk code call pud_entry only for huge puds with the page-table
> lock held, whereas the hmm callback appears to assume it gets called
> unconditionally without the page-table lock held?
> 
> Could you shed some light into this?

I think in my mind they were already unified :) I think easiest thing is
to remove the hmm pud walker, this is not a big deal this will break huge
pud for now, we can re-add this to hmm once you unified them.

Cheers,
Jérôme

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-07 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-05 12:29 hmm pud-entry callback locking? Thomas Hellström (VMware)
2019-10-07 14:19 ` Jerome Glisse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).