From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Pavel Machek <pavel@ucw.cz>, vadimp@mellanox.com
Cc: rpurdie@rpsys.net, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, jiri@resnulli.us,
michaelsh@mellanox.com
Subject: Re: [patch] leds: add driver for Mellanox systems leds
Date: Thu, 15 Sep 2016 16:53:58 +0200 [thread overview]
Message-ID: <4d4c0a66-f4e3-c37b-817d-495ff1b2f0d3@samsung.com> (raw)
In-Reply-To: <20160915125222.GG13132@amd>
Hi Pavel,
On 09/15/2016 02:52 PM, Pavel Machek wrote:
> Hi!
>
>> +++ b/MAINTAINERS
>> @@ -7655,6 +7655,14 @@ W: http://www.mellanox.com
>> Q: http://patchwork.ozlabs.org/project/netdev/list/
>> F: drivers/net/ethernet/mellanox/mlxsw/
>>
>> +MELLANOX MLXCPLD LED DRIVER
>> +M: Vadim Pasternak <vadimp@mellanox.com>
>> +L: linux-leds@vger.kernel.org
>> +S: Supported
>> +W: http://www.mellanox.com
>
> Unless you have web page specificly about the LED hardware, I don't
> think W: tag is useful here.
>
I raised also similar objections during review. Eventually I left
the entry after skimming through the MAINTAINERS and noticing few
other similar examples.
In fact, the link to the main page doesn't convey any better information
than can be obtained after searching google. I'm dropping the entry
then.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2016-09-15 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 13:35 [patch] leds: add driver for Mellanox systems leds vadimp
2016-09-07 12:11 ` Dr. David Alan Gilbert
2016-09-07 12:18 ` Vadim Pasternak
2016-09-07 12:49 ` Jacek Anaszewski
2016-09-07 12:59 ` Jiri Pirko
2016-09-07 13:01 ` Vadim Pasternak
2016-09-15 12:52 ` Pavel Machek
2016-09-15 14:53 ` Jacek Anaszewski [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-29 18:07 [patch] leds: add driver for Mellanox systems LEDs vadimp
2016-08-31 13:10 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d4c0a66-f4e3-c37b-817d-495ff1b2f0d3@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).