linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: vadimp@mellanox.com, rpurdie@rpsys.net
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	jiri@resnulli.us, michaelsh@mellanox.com
Subject: Re: [patch] leds: add driver for Mellanox systems leds
Date: Wed, 07 Sep 2016 14:49:00 +0200	[thread overview]
Message-ID: <7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com> (raw)
In-Reply-To: <1473255323-191745-1-git-send-email-vadimp@mellanox.com>

Hi Vadim,

On 09/07/2016 03:35 PM, vadimp@mellanox.com wrote:
> From: Vadim Pasternak <vadimp@mellanox.com>
>
> This makes it possible to create a set of LEDs for Mellanox systems:
> "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
> "msb7800", "msn2740", "msn2100".
>
> Driver obtains led devices according to system configuration, provided
> through system DMI data, like fan1:green, fan1:red and creates devices in
> form: "devicename:colour:function".
>
> led setting is controlled through on board CPLD Lattice device.
> For setting particular led off, solid,
> blink (blink requires ledtrig-timer module):
> echo 0 > /sys/class/leds/status\:green/brightness
> echo 1 > /sys/class/leds/status\:green/brightness
> echo timer > /sys/class/leds/status\:green/trigger
>

Thanks for the update, will review it soon.

One important detail - please update patch version each time
you're sending a new one, like [PATCH v2].

-- 
Best regards,
Jacek Anaszewski

  parent reply	other threads:[~2016-09-07 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 13:35 [patch] leds: add driver for Mellanox systems leds vadimp
2016-09-07 12:11 ` Dr. David Alan Gilbert
2016-09-07 12:18   ` Vadim Pasternak
2016-09-07 12:49 ` Jacek Anaszewski [this message]
2016-09-07 12:59   ` Jiri Pirko
2016-09-07 13:01   ` Vadim Pasternak
2016-09-15 12:52 ` Pavel Machek
2016-09-15 14:53   ` Jacek Anaszewski
  -- strict thread matches above, loose matches on Subject: below --
2016-08-29 18:07 [patch] leds: add driver for Mellanox systems LEDs vadimp
2016-08-31 13:10 ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=michaelsh@mellanox.com \
    --cc=rpurdie@rpsys.net \
    --cc=vadimp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).