From: "Christian König" <christian.koenig@amd.com>
To: Joe Perches <joe@perches.com>, Jiri Kosina <trivial@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
Date: Wed, 3 Feb 2021 14:26:16 +0100 [thread overview]
Message-ID: <4d5891b7-ea87-974e-d260-f78c3af326bc@amd.com> (raw)
In-Reply-To: <a87b95d11c22d997ebc423bba71cabef15ca0bac.camel@perches.com>
Am 30.01.21 um 19:47 schrieb Joe Perches:
> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
>> Use semicolons and braces.
> Ping?
>
>> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Do you have commit rights to drm-misc-next?
>> ---
>> drivers/dma-buf/st-dma-fence.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
>> index e593064341c8..c8a12d7ad71a 100644
>> --- a/drivers/dma-buf/st-dma-fence.c
>> +++ b/drivers/dma-buf/st-dma-fence.c
>> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>> dma_fence_signal(f1);
>>
>>
>> smp_store_mb(cb.seen, false);
>> - if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
>> - miss++, cb.seen = true;
>> + if (!f2 ||
>> + dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
>> + miss++;
>> + cb.seen = true;
>> + }
>>
>>
>> if (!t->before)
>> dma_fence_signal(f1);
>
next prev parent reply other threads:[~2021-01-31 20:10 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
2020-08-25 4:55 ` [PATCH 01/29] coding-style.rst: Avoid comma statements Joe Perches
2021-01-30 18:53 ` Joe Perches
2021-02-04 21:41 ` Jonathan Corbet
2020-08-25 4:55 ` [PATCH 02/29] alpha: Avoid comma separated statements Joe Perches
2020-08-25 6:37 ` Robert Richter
2021-01-30 18:54 ` Joe Perches
2021-02-16 14:39 ` Robert Richter
2021-02-16 15:10 ` Joe Perches
2020-08-25 4:56 ` [PATCH 03/29] ia64: " Joe Perches
2021-01-30 18:55 ` Joe Perches
2020-08-25 4:56 ` [PATCH 04/29] sparc: " Joe Perches
2021-01-30 18:56 ` Joe Perches
2020-08-25 4:56 ` [PATCH 05/29] ata: " Joe Perches
2021-01-30 18:56 ` Joe Perches
2021-01-31 15:06 ` Jens Axboe
2020-08-25 4:56 ` [PATCH 06/29] drbd: " Joe Perches
2021-01-30 18:57 ` Joe Perches
2021-01-31 15:06 ` Jens Axboe
2020-08-25 4:56 ` [PATCH 07/29] lp: " Joe Perches
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: " Joe Perches
2020-08-26 15:08 ` Christian König
2020-09-03 12:21 ` Sumit Semwal
2020-09-04 11:42 ` Kieran Bingham
2020-09-04 21:33 ` Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-02-03 13:26 ` Christian König [this message]
2021-01-31 17:39 ` Joe Perches
2021-01-31 17:53 ` Christian König
2021-02-01 21:54 ` Lyude Paul
2021-02-02 8:33 ` [Linaro-mm-sig] " Christian König
2021-02-02 18:24 ` Lyude Paul
2020-08-25 4:56 ` [PATCH 09/29] drm/gma500: " Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-01-30 21:21 ` Patrik Jakobsson
2020-08-25 4:56 ` [PATCH 10/29] drm/i915: " Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-02-01 8:41 ` Jani Nikula
2020-08-25 4:56 ` [PATCH 11/29] hwmon: (scmi-hwmon): " Joe Perches
2020-08-25 23:33 ` Guenter Roeck
2020-08-25 4:56 ` [PATCH 12/29] Input: MT - " Joe Perches
2020-08-25 17:07 ` Dmitry Torokhov
2020-08-25 4:56 ` [PATCH 13/29] bcache: " Joe Perches
2021-01-30 18:59 ` Joe Perches
2021-01-31 15:58 ` Coly Li
2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches
2020-09-04 11:45 ` Kieran Bingham
2020-08-25 4:56 ` [PATCH 15/29] mtd: " Joe Perches
2020-09-07 7:34 ` Miquel Raynal
2020-08-25 4:56 ` [PATCH 16/29] 8390: " Joe Perches
2020-08-25 14:54 ` David Miller
2020-08-25 4:56 ` [PATCH 17/29] fs_enet: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 18/29] wan: sbni: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 19/29] s390/tty3270: " Joe Perches
2021-01-30 19:01 ` Joe Perches
2020-08-25 4:56 ` [PATCH 20/29] scai/arm: " Joe Perches
2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches
2020-09-04 11:46 ` Kieran Bingham
2020-08-25 4:56 ` [PATCH 22/29] video: fbdev: " Joe Perches
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
2020-08-25 4:56 ` [PATCH 23/29] fuse: " Joe Perches
2021-01-30 19:04 ` Joe Perches
2021-02-01 8:12 ` Miklos Szeredi
2020-08-25 4:56 ` [PATCH 24/29] reiserfs: " Joe Perches
2021-01-30 19:04 ` Joe Perches
2020-08-25 4:56 ` [PATCH 25/29] lib/zlib: " Joe Perches
2021-01-30 19:05 ` Joe Perches
2020-08-25 4:56 ` [PATCH 26/29] lib: zstd: " Joe Perches
2021-01-30 19:06 ` Joe Perches
2020-08-25 4:56 ` [PATCH 27/29] ipv6: fib6: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 28/29] sunrpc: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 29/29] tools: " Joe Perches
2020-08-26 9:30 ` Thomas Renninger
2020-08-26 14:45 ` Joe Perches
2020-08-26 16:13 ` Thomas Renninger
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5891b7-ea87-974e-d260-f78c3af326bc@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).