From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 25/29] lib/zlib: Avoid comma separated statements
Date: Sat, 30 Jan 2021 11:05:24 -0800 [thread overview]
Message-ID: <ae5fc838475df9479d48302f9bbdec026274dbf6.camel@perches.com> (raw)
In-Reply-To: <26b46a75251b8889a3c857461771f9a4115220e3.1598331149.git.joe@perches.com>
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
ping?
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> lib/zlib_deflate/deftree.c | 49 +++++++++++++++++++++++++++-----------
> 1 file changed, 35 insertions(+), 14 deletions(-)
>
> diff --git a/lib/zlib_deflate/deftree.c b/lib/zlib_deflate/deftree.c
> index a4a34da512fe..e358053bdb15 100644
> --- a/lib/zlib_deflate/deftree.c
> +++ b/lib/zlib_deflate/deftree.c
> @@ -217,10 +217,22 @@ static void tr_static_init(void)
> /* Construct the codes of the static literal tree */
> for (bits = 0; bits <= MAX_BITS; bits++) bl_count[bits] = 0;
> n = 0;
> - while (n <= 143) static_ltree[n++].Len = 8, bl_count[8]++;
> - while (n <= 255) static_ltree[n++].Len = 9, bl_count[9]++;
> - while (n <= 279) static_ltree[n++].Len = 7, bl_count[7]++;
> - while (n <= 287) static_ltree[n++].Len = 8, bl_count[8]++;
> + while (n <= 143) {
> + static_ltree[n++].Len = 8;
> + bl_count[8]++;
> + }
> + while (n <= 255) {
> + static_ltree[n++].Len = 9;
> + bl_count[9]++;
> + }
> + while (n <= 279) {
> + static_ltree[n++].Len = 7;
> + bl_count[7]++;
> + }
> + while (n <= 287) {
> + static_ltree[n++].Len = 8;
> + bl_count[8]++;
> + }
> /* Codes 286 and 287 do not exist, but we must include them in the
> * tree construction to get a canonical Huffman tree (longest code
> * all ones)
> @@ -378,7 +390,10 @@ static void gen_bitlen(
> for (h = s->heap_max+1; h < HEAP_SIZE; h++) {
> n = s->heap[h];
> bits = tree[tree[n].Dad].Len + 1;
> - if (bits > max_length) bits = max_length, overflow++;
> + if (bits > max_length) {
> + bits = max_length;
> + overflow++;
> + }
> tree[n].Len = (ush)bits;
> /* We overwrite tree[n].Dad which is no longer needed */
>
>
> @@ -497,7 +512,7 @@ static void build_tree(
> * heap[SMALLEST]. The sons of heap[n] are heap[2*n] and heap[2*n+1].
> * heap[0] is not used.
> */
> - s->heap_len = 0, s->heap_max = HEAP_SIZE;
> + s->heap_len = 0; s->heap_max = HEAP_SIZE;
>
>
> for (n = 0; n < elems; n++) {
> if (tree[n].Freq != 0) {
> @@ -583,7 +598,10 @@ static void scan_tree(
> int max_count = 7; /* max repeat count */
> int min_count = 4; /* min repeat count */
>
>
> - if (nextlen == 0) max_count = 138, min_count = 3;
> + if (nextlen == 0) {
> + max_count = 138;
> + min_count = 3;
> + }
> tree[max_code+1].Len = (ush)0xffff; /* guard */
>
>
> for (n = 0; n <= max_code; n++) {
> @@ -602,11 +620,11 @@ static void scan_tree(
> }
> count = 0; prevlen = curlen;
> if (nextlen == 0) {
> - max_count = 138, min_count = 3;
> + max_count = 138; min_count = 3;
> } else if (curlen == nextlen) {
> - max_count = 6, min_count = 3;
> + max_count = 6; min_count = 3;
> } else {
> - max_count = 7, min_count = 4;
> + max_count = 7; min_count = 4;
> }
> }
> }
> @@ -630,7 +648,10 @@ static void send_tree(
> int min_count = 4; /* min repeat count */
>
>
> /* tree[max_code+1].Len = -1; */ /* guard already set */
> - if (nextlen == 0) max_count = 138, min_count = 3;
> + if (nextlen == 0) {
> + max_count = 138;
> + min_count = 3;
> + }
>
>
> for (n = 0; n <= max_code; n++) {
> curlen = nextlen; nextlen = tree[n+1].Len;
> @@ -654,11 +675,11 @@ static void send_tree(
> }
> count = 0; prevlen = curlen;
> if (nextlen == 0) {
> - max_count = 138, min_count = 3;
> + max_count = 138; min_count = 3;
> } else if (curlen == nextlen) {
> - max_count = 6, min_count = 3;
> + max_count = 6; min_count = 3;
> } else {
> - max_count = 7, min_count = 4;
> + max_count = 7; min_count = 4;
> }
> }
> }
next prev parent reply other threads:[~2021-01-30 19:06 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 4:55 [PATCH 00/29] treewide: Convert comma separated statements Joe Perches
2020-08-25 4:55 ` [PATCH 01/29] coding-style.rst: Avoid comma statements Joe Perches
2021-01-30 18:53 ` Joe Perches
2021-02-04 21:41 ` Jonathan Corbet
2020-08-25 4:55 ` [PATCH 02/29] alpha: Avoid comma separated statements Joe Perches
2020-08-25 6:37 ` Robert Richter
2021-01-30 18:54 ` Joe Perches
2021-02-16 14:39 ` Robert Richter
2021-02-16 15:10 ` Joe Perches
2020-08-25 4:56 ` [PATCH 03/29] ia64: " Joe Perches
2021-01-30 18:55 ` Joe Perches
2020-08-25 4:56 ` [PATCH 04/29] sparc: " Joe Perches
2021-01-30 18:56 ` Joe Perches
2020-08-25 4:56 ` [PATCH 05/29] ata: " Joe Perches
2021-01-30 18:56 ` Joe Perches
2021-01-31 15:06 ` Jens Axboe
2020-08-25 4:56 ` [PATCH 06/29] drbd: " Joe Perches
2021-01-30 18:57 ` Joe Perches
2021-01-31 15:06 ` Jens Axboe
2020-08-25 4:56 ` [PATCH 07/29] lp: " Joe Perches
2020-08-25 4:56 ` [PATCH 08/29] dma-buf: " Joe Perches
2020-08-26 15:08 ` Christian König
2020-09-03 12:21 ` Sumit Semwal
2020-09-04 11:42 ` Kieran Bingham
2020-09-04 21:33 ` Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-02-03 13:26 ` Christian König
2021-01-31 17:39 ` Joe Perches
2021-01-31 17:53 ` Christian König
2021-02-01 21:54 ` Lyude Paul
2021-02-02 8:33 ` [Linaro-mm-sig] " Christian König
2021-02-02 18:24 ` Lyude Paul
2020-08-25 4:56 ` [PATCH 09/29] drm/gma500: " Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-01-30 21:21 ` Patrik Jakobsson
2020-08-25 4:56 ` [PATCH 10/29] drm/i915: " Joe Perches
2021-01-30 18:47 ` Joe Perches
2021-02-01 8:41 ` Jani Nikula
2020-08-25 4:56 ` [PATCH 11/29] hwmon: (scmi-hwmon): " Joe Perches
2020-08-25 23:33 ` Guenter Roeck
2020-08-25 4:56 ` [PATCH 12/29] Input: MT - " Joe Perches
2020-08-25 17:07 ` Dmitry Torokhov
2020-08-25 4:56 ` [PATCH 13/29] bcache: " Joe Perches
2021-01-30 18:59 ` Joe Perches
2021-01-31 15:58 ` Coly Li
2020-08-25 4:56 ` [PATCH 14/29] media: " Joe Perches
2020-09-04 11:45 ` Kieran Bingham
2020-08-25 4:56 ` [PATCH 15/29] mtd: " Joe Perches
2020-09-07 7:34 ` Miquel Raynal
2020-08-25 4:56 ` [PATCH 16/29] 8390: " Joe Perches
2020-08-25 14:54 ` David Miller
2020-08-25 4:56 ` [PATCH 17/29] fs_enet: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 18/29] wan: sbni: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 19/29] s390/tty3270: " Joe Perches
2021-01-30 19:01 ` Joe Perches
2020-08-25 4:56 ` [PATCH 20/29] scai/arm: " Joe Perches
2020-08-25 4:56 ` [PATCH 21/29] media: atomisp: " Joe Perches
2020-09-04 11:46 ` Kieran Bingham
2020-08-25 4:56 ` [PATCH 22/29] video: fbdev: " Joe Perches
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
2020-08-25 4:56 ` [PATCH 23/29] fuse: " Joe Perches
2021-01-30 19:04 ` Joe Perches
2021-02-01 8:12 ` Miklos Szeredi
2020-08-25 4:56 ` [PATCH 24/29] reiserfs: " Joe Perches
2021-01-30 19:04 ` Joe Perches
2020-08-25 4:56 ` [PATCH 25/29] lib/zlib: " Joe Perches
2021-01-30 19:05 ` Joe Perches [this message]
2020-08-25 4:56 ` [PATCH 26/29] lib: zstd: " Joe Perches
2021-01-30 19:06 ` Joe Perches
2020-08-25 4:56 ` [PATCH 27/29] ipv6: fib6: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 28/29] sunrpc: " Joe Perches
2020-08-25 14:55 ` David Miller
2020-08-25 4:56 ` [PATCH 29/29] tools: " Joe Perches
2020-08-26 9:30 ` Thomas Renninger
2020-08-26 14:45 ` Joe Perches
2020-08-26 16:13 ` Thomas Renninger
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae5fc838475df9479d48302f9bbdec026274dbf6.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).