From: Jose Abreu <Jose.Abreu@synopsys.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: [PATCH net-next 16/18] net: stmmac: dwxgmac2: Do not disable whole RX in dma_stop_rx()
Date: Thu, 23 May 2019 09:37:06 +0200 [thread overview]
Message-ID: <4d8827e2904c0d27e08363fe2bc9b0a9cd7a544b.1558596600.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1558596599.git.joabreu@synopsys.com>
In-Reply-To: <cover.1558596599.git.joabreu@synopsys.com>
We don't need to disable the whole RX when dma_stop_rx() is called
because there may be the need of just disabling 1 DMA channel.
This is also needed for stmmac Flow Control selftest.
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index e79037f511e1..7861a938420a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -299,10 +299,6 @@ static void dwxgmac2_dma_stop_rx(void __iomem *ioaddr, u32 chan)
value = readl(ioaddr + XGMAC_DMA_CH_RX_CONTROL(chan));
value &= ~XGMAC_RXST;
writel(value, ioaddr + XGMAC_DMA_CH_RX_CONTROL(chan));
-
- value = readl(ioaddr + XGMAC_RX_CONFIG);
- value &= ~XGMAC_CONFIG_RE;
- writel(value, ioaddr + XGMAC_RX_CONFIG);
}
static int dwxgmac2_dma_interrupt(void __iomem *ioaddr,
--
2.7.4
next prev parent reply other threads:[~2019-05-23 7:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 7:36 [PATCH net-next 00/18] net: stmmac: Improvements and Selftests Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 01/18] net: stmmac: Add MAC loopback callback to HWIF Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 02/18] net: stmmac: dwmac100: Add MAC loopback support Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 03/18] net: stmmac: dwmac1000: " Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 04/18] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 05/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 06/18] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 07/18] net: stmmac: Switch MMC functions to HWIF callbacks Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 08/18] net: stmmac: dwmac1000: Also pass control frames while in promisc mode Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 09/18] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 10/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 11/18] net: stmmac: Introduce selftests support Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 12/18] net: stmmac: dwmac1000: Fix Hash Filter Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 13/18] net: stmmac: dwmac1000: Clear unused address entries Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 14/18] net: stmmac: dwmac4/5: Fix Hash Filter Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 15/18] net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx() Jose Abreu
2019-05-23 7:37 ` Jose Abreu [this message]
2019-05-23 7:37 ` [PATCH net-next 17/18] net: stmmac: dwmac4/5: Clear unused address entries Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 18/18] net: stmmac: Prevent missing interrupts when running NAPI Jose Abreu
2019-05-23 16:09 ` [PATCH net-next 00/18] net: stmmac: Improvements and Selftests David Miller
2019-05-23 16:18 ` David Miller
2019-05-24 7:24 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8827e2904c0d27e08363fe2bc9b0a9cd7a544b.1558596600.git.joabreu@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).