From: Jose Abreu <Jose.Abreu@synopsys.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: [PATCH net-next 17/18] net: stmmac: dwmac4/5: Clear unused address entries
Date: Thu, 23 May 2019 09:37:07 +0200 [thread overview]
Message-ID: <83f187d192b6c43262d23a56a68096ffff71fa7a.1558596600.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1558596599.git.joabreu@synopsys.com>
In-Reply-To: <cover.1558596599.git.joabreu@synopsys.com>
In case we don't use a given address entry we need to clear it because
it could contain previous values that are no longer valid.
Found out while running stmmac selftests.
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index 094bd069c093..9f14943ca34c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -446,14 +446,20 @@ static void dwmac4_set_filter(struct mac_device_info *hw,
* are required
*/
value |= GMAC_PACKET_FILTER_PR;
- } else if (!netdev_uc_empty(dev)) {
- int reg = 1;
+ } else {
struct netdev_hw_addr *ha;
+ int reg = 1;
netdev_for_each_uc_addr(ha, dev) {
dwmac4_set_umac_addr(hw, ha->addr, reg);
reg++;
}
+
+ while (reg <= GMAC_MAX_PERFECT_ADDRESSES) {
+ writel(0, ioaddr + GMAC_ADDR_HIGH(reg));
+ writel(0, ioaddr + GMAC_ADDR_LOW(reg));
+ reg++;
+ }
}
writel(value, ioaddr + GMAC_PACKET_FILTER);
--
2.7.4
next prev parent reply other threads:[~2019-05-23 7:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 7:36 [PATCH net-next 00/18] net: stmmac: Improvements and Selftests Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 01/18] net: stmmac: Add MAC loopback callback to HWIF Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 02/18] net: stmmac: dwmac100: Add MAC loopback support Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 03/18] net: stmmac: dwmac1000: " Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 04/18] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 05/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 06/18] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 07/18] net: stmmac: Switch MMC functions to HWIF callbacks Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 08/18] net: stmmac: dwmac1000: Also pass control frames while in promisc mode Jose Abreu
2019-05-23 7:36 ` [PATCH net-next 09/18] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 10/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 11/18] net: stmmac: Introduce selftests support Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 12/18] net: stmmac: dwmac1000: Fix Hash Filter Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 13/18] net: stmmac: dwmac1000: Clear unused address entries Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 14/18] net: stmmac: dwmac4/5: Fix Hash Filter Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 15/18] net: stmmac: dwmac4/5: Do not disable whole RX in dma_stop_rx() Jose Abreu
2019-05-23 7:37 ` [PATCH net-next 16/18] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-23 7:37 ` Jose Abreu [this message]
2019-05-23 7:37 ` [PATCH net-next 18/18] net: stmmac: Prevent missing interrupts when running NAPI Jose Abreu
2019-05-23 16:09 ` [PATCH net-next 00/18] net: stmmac: Improvements and Selftests David Miller
2019-05-23 16:18 ` David Miller
2019-05-24 7:24 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83f187d192b6c43262d23a56a68096ffff71fa7a.1558596600.git.joabreu@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).