From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Evan Green <evgreen@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3 2/5] arm64: dts: qcom: msm8998: Allow drivers to set-load
Date: Mon, 4 Feb 2019 11:06:52 -0700 [thread overview]
Message-ID: <4d99d729-d59c-e799-b4f2-8874372c9e63@codeaurora.org> (raw)
In-Reply-To: <31108a78-e158-5147-2f2f-cd300cb5d49b@free.fr>
On 2/4/2019 10:37 AM, Marc Gonzalez wrote:
> The UFS host controller driver needs to set the load on 3 power rails
> (l20, l26, s4) but the operation fails silently unless we specify the
> regulator-allow-set-load property in the corresponding DT nodes.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> index 80075283847a..198885db775e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
> @@ -104,6 +104,7 @@
> vreg_s4a_1p8: s4 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> + regulator-allow-set-load;
> };
> vreg_s5a_2p04: s5 {
> regulator-min-microvolt = <1904000>;
> @@ -188,6 +189,7 @@
> vreg_l20a_2p95: l20 {
> regulator-min-microvolt = <2960000>;
> regulator-max-microvolt = <2960000>;
> + regulator-allow-set-load;
> };
> vreg_l21a_2p95: l21 {
> regulator-min-microvolt = <2960000>;
> @@ -212,6 +214,7 @@
> vreg_l26a_1p2: l26 {
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> + regulator-allow-set-load;
> };
> vreg_l28_3p0: l28 {
> regulator-min-microvolt = <3008000>;
>
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-02-04 18:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 17:34 [PATCH v3 0/5] UFS on APQ8098/MSM8998 Marc Gonzalez
2019-02-04 17:36 ` [PATCH v3 1/5] arm64: dts: qcom: msm8998: Add UFS nodes Marc Gonzalez
2019-02-04 18:06 ` Jeffrey Hugo
2019-02-06 10:58 ` Marc Gonzalez
2019-02-04 17:37 ` [PATCH v3 2/5] arm64: dts: qcom: msm8998: Allow drivers to set-load Marc Gonzalez
2019-02-04 18:06 ` Jeffrey Hugo [this message]
2019-02-04 17:38 ` [PATCH v3 3/5] dt-bindings: phy-qcom-qmp: Add qcom,msm8998-qmp-ufs-phy Marc Gonzalez
2019-02-04 18:08 ` Jeffrey Hugo
2019-02-04 17:39 ` [PATCH v3 4/5] phy: qcom-qmp: Add QMP UFS PHY support for msm8998 Marc Gonzalez
2019-02-04 18:10 ` Jeffrey Hugo
2019-02-06 12:39 ` Kishon Vijay Abraham I
2019-02-06 12:44 ` Marc Gonzalez
2019-02-04 17:42 ` [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device" Marc Gonzalez
2019-02-04 18:11 ` Jeffrey Hugo
2019-02-04 19:51 ` Avri Altman
2019-02-04 20:23 ` Jeffrey Hugo
2019-02-04 20:27 ` Bjorn Andersson
2019-02-05 4:58 ` Alim Akhtar
2019-02-05 6:27 ` Bjorn Andersson
2019-02-05 10:52 ` Alim Akhtar
2019-02-05 19:46 ` Bjorn Andersson
2019-02-06 15:23 ` Alim Akhtar
2019-02-05 17:24 ` Marc Gonzalez
2019-02-05 17:51 ` Marc Gonzalez
2019-02-05 18:19 ` Evan Green
2019-02-05 19:37 ` Jeffrey Hugo
2019-02-06 14:53 ` Marc Gonzalez
2019-02-06 14:59 ` Marc Gonzalez
2019-02-06 15:27 ` Alim Akhtar
2019-02-06 15:52 ` Marc Gonzalez
2019-02-07 8:50 ` Alim Akhtar
2019-02-07 14:52 ` Jeffrey Hugo
2019-02-08 9:09 ` Alim Akhtar
2019-02-08 10:03 ` Marc Gonzalez
2019-02-08 14:59 ` Jeffrey Hugo
2019-02-09 8:42 ` Alim Akhtar
2019-02-09 11:49 ` Marc Gonzalez
2019-02-10 15:58 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d99d729-d59c-e799-b4f2-8874372c9e63@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).