* [PATCH] powerpc: Make some symbols static
@ 2021-04-07 12:59 Yu Kuai
2021-04-07 16:57 ` kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: Yu Kuai @ 2021-04-07 12:59 UTC (permalink / raw)
To: mpe; +Cc: linuxppc-dev, linux-kernel, yukuai3, yi.zhang
The sparse tool complains as follows:
arch/powerpc/kernel/btext.c:48:5: warning:
symbol 'boot_text_mapped' was not declared. Should it be static?
arch/powerpc/kernel/btext.c:49:5: warning:
symbol 'force_printk_to_btext' was not declared. Should it be static?
These symbols are not used outside of btext.c, so this
commit marks them static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
arch/powerpc/kernel/btext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/btext.c b/arch/powerpc/kernel/btext.c
index 803c2a45b22a..6323304d7f6e 100644
--- a/arch/powerpc/kernel/btext.c
+++ b/arch/powerpc/kernel/btext.c
@@ -45,8 +45,8 @@ unsigned long disp_BAT[2] __initdata = {0, 0};
static unsigned char vga_font[cmapsz];
-int boot_text_mapped __force_data = 0;
-int force_printk_to_btext = 0;
+static int boot_text_mapped __force_data;
+static int force_printk_to_btext;
extern void rmci_on(void);
extern void rmci_off(void);
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Make some symbols static
2021-04-07 12:59 [PATCH] powerpc: Make some symbols static Yu Kuai
@ 2021-04-07 16:57 ` kernel test robot
2021-04-08 1:11 ` yukuai (C)
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-04-07 16:57 UTC (permalink / raw)
To: Yu Kuai, mpe; +Cc: kbuild-all, yukuai3, linuxppc-dev, linux-kernel, yi.zhang
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.12-rc6 next-20210407]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yu-Kuai/powerpc-Make-some-symbols-static/20210407-205258
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7c0f3f68006b9b42ce944b02a2059128cc5826ec
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yu-Kuai/powerpc-Make-some-symbols-static/20210407-205258
git checkout 7c0f3f68006b9b42ce944b02a2059128cc5826ec
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' defined but not used [-Werror=unused-variable]
49 | static int force_printk_to_btext;
| ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/force_printk_to_btext +49 arch/powerpc/kernel/btext.c
47
48 static int boot_text_mapped __force_data;
> 49 static int force_printk_to_btext;
50
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26728 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Make some symbols static
2021-04-07 16:57 ` kernel test robot
@ 2021-04-08 1:11 ` yukuai (C)
0 siblings, 0 replies; 3+ messages in thread
From: yukuai (C) @ 2021-04-08 1:11 UTC (permalink / raw)
To: kernel test robot, mpe; +Cc: kbuild-all, linuxppc-dev, linux-kernel, yi.zhang
On 2021/04/08 0:57, kernel test robot wrote:
> Hi Yu,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on powerpc/next]
> [also build test ERROR on v5.12-rc6 next-20210407]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Yu-Kuai/powerpc-Make-some-symbols-static/20210407-205258
> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> config: powerpc64-defconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/7c0f3f68006b9b42ce944b02a2059128cc5826ec
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Yu-Kuai/powerpc-Make-some-symbols-static/20210407-205258
> git checkout 7c0f3f68006b9b42ce944b02a2059128cc5826ec
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>>> arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' defined but not used [-Werror=unused-variable]
> 49 | static int force_printk_to_btext;
> | ^~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
>
> vim +/force_printk_to_btext +49 arch/powerpc/kernel/btext.c
>
> 47
> 48 static int boot_text_mapped __force_data;
> > 49 static int force_printk_to_btext;
> 50
Will remove this variable in another patch.
Thanks
Yu Kuai
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-08 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 12:59 [PATCH] powerpc: Make some symbols static Yu Kuai
2021-04-07 16:57 ` kernel test robot
2021-04-08 1:11 ` yukuai (C)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).