From: Subhash Jadavani <subhashj@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: Re: [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging
Date: Fri, 20 Jan 2017 14:54:25 -0800 [thread overview]
Message-ID: <4e47248021c9344a33a76f931fa7b35e@codeaurora.org> (raw)
In-Reply-To: <20170119104739.4376-4-bjorn.andersson@linaro.org>
On 2017-01-19 02:47, Bjorn Andersson wrote:
> The error paths of the common qcom-ufs functions for registering the
> phy, acquiring clocks and acquiring regulators all print specific error
> messages before returning an error, so there is no value in printing
> yet
> another - more generic - message when this occur.
>
> Cc: Subhash Jadavani <subhashj@codeaurora.org>
> Cc: Vivek Gautam <vivek.gautam@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++------------
> drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++----------
> 2 files changed, 5 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> index c71c84734916..12a1b498dc4b 100644
> --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> @@ -132,27 +132,18 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct
> platform_device *pdev)
> &ufs_qcom_phy_qmp_14nm_phy_ops, &phy_14nm_ops);
>
> if (!generic_phy) {
> - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n",
> - __func__);
> err = -EIO;
> goto out;
> }
>
> err = ufs_qcom_phy_init_clks(phy_common);
> - if (err) {
> - dev_err(phy_common->dev,
> - "%s: ufs_qcom_phy_init_clks() failed %d\n",
> - __func__, err);
> + if (err)
> goto out;
> - }
>
> err = ufs_qcom_phy_init_vregulators(phy_common);
> - if (err) {
> - dev_err(phy_common->dev,
> - "%s: ufs_qcom_phy_init_vregulators() failed %d\n",
> - __func__, err);
> + if (err)
> goto out;
> - }
> +
> phy_common->vdda_phy.max_uV = UFS_PHY_VDDA_PHY_UV;
> phy_common->vdda_phy.min_uV = UFS_PHY_VDDA_PHY_UV;
>
> diff --git a/drivers/phy/phy-qcom-ufs-qmp-20nm.c
> b/drivers/phy/phy-qcom-ufs-qmp-20nm.c
> index 1a26a64e06d3..4f68acb58b73 100644
> --- a/drivers/phy/phy-qcom-ufs-qmp-20nm.c
> +++ b/drivers/phy/phy-qcom-ufs-qmp-20nm.c
> @@ -190,25 +190,17 @@ static int ufs_qcom_phy_qmp_20nm_probe(struct
> platform_device *pdev)
> &ufs_qcom_phy_qmp_20nm_phy_ops, &phy_20nm_ops);
>
> if (!generic_phy) {
> - dev_err(dev, "%s: ufs_qcom_phy_generic_probe() failed\n",
> - __func__);
> err = -EIO;
> goto out;
> }
>
> err = ufs_qcom_phy_init_clks(phy_common);
> - if (err) {
> - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_clks() failed %d\n",
> - __func__, err);
> + if (err)
> goto out;
> - }
>
> err = ufs_qcom_phy_init_vregulators(phy_common);
> - if (err) {
> - dev_err(phy_common->dev, "%s: ufs_qcom_phy_init_vregulators() failed
> %d\n",
> - __func__, err);
> + if (err)
> goto out;
> - }
>
> ufs_qcom_phy_qmp_20nm_advertise_quirks(phy_common);
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-20 22:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 10:47 [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource Bjorn Andersson
2017-01-19 10:47 ` [PATCH 2/4] phy: qcom-ufs: Correct usage of regulator_get() Bjorn Andersson
2017-01-19 19:33 ` vivek.gautam
2017-01-20 22:50 ` Subhash Jadavani
2017-01-19 10:47 ` [PATCH 3/4] phy: qcom-ufs: Remove -always-on property Bjorn Andersson
2017-01-19 19:39 ` Vivek Gautam
2017-01-20 22:53 ` Subhash Jadavani
2017-01-21 20:43 ` Rob Herring
2017-01-19 10:47 ` [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging Bjorn Andersson
2017-01-19 20:07 ` Vivek Gautam
2017-01-20 22:54 ` Subhash Jadavani [this message]
2017-01-19 20:09 ` [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource Vivek Gautam
2017-01-20 20:10 ` Subhash Jadavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e47248021c9344a33a76f931fa7b35e@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).