From: Subhash Jadavani <subhashj@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: Re: [PATCH 2/4] phy: qcom-ufs: Correct usage of regulator_get()
Date: Fri, 20 Jan 2017 14:50:44 -0800 [thread overview]
Message-ID: <a810cc0c93dbceb15b8375450e4c7303@codeaurora.org> (raw)
In-Reply-To: <20170119104739.4376-2-bjorn.andersson@linaro.org>
On 2017-01-19 02:47, Bjorn Andersson wrote:
> When regulator_get() tries to resolve a regulator supply but fail to
> find a matching property in DeviceTree it returns a dummy regulator, if
> a matching supply is specified but unavailable the regulator core will
> return an error.
>
> Based on this we should not ignore errors upon failing to acquire the
> optional "vddp-ref-clk" supply.
>
> Cc: Subhash Jadavani <subhashj@codeaurora.org>
> Cc: Vivek Gautam <vivek.gautam@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/phy/phy-qcom-ufs.c | 21 +++++++--------------
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index 4d7f3c018223..bbd317158084 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -210,8 +210,9 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy
> *phy_common)
> }
> EXPORT_SYMBOL_GPL(ufs_qcom_phy_init_clks);
>
> -static int __ufs_qcom_phy_init_vreg(struct device *dev,
> - struct ufs_qcom_phy_vreg *vreg, const char *name, bool optional)
> +static int ufs_qcom_phy_init_vreg(struct device *dev,
> + struct ufs_qcom_phy_vreg *vreg,
> + const char *name)
> {
> int err = 0;
>
> @@ -221,9 +222,7 @@ static int __ufs_qcom_phy_init_vreg(struct device
> *dev,
> vreg->reg = devm_regulator_get(dev, name);
> if (IS_ERR(vreg->reg)) {
> err = PTR_ERR(vreg->reg);
> - vreg->reg = NULL;
> - if (!optional)
> - dev_err(dev, "failed to get %s, %d\n", name, err);
> + dev_err(dev, "failed to get %s, %d\n", name, err);
> goto out;
> }
>
> @@ -263,12 +262,6 @@ static int __ufs_qcom_phy_init_vreg(struct device
> *dev,
> return err;
> }
>
> -static int ufs_qcom_phy_init_vreg(struct device *dev,
> - struct ufs_qcom_phy_vreg *vreg, const char *name)
> -{
> - return __ufs_qcom_phy_init_vreg(dev, vreg, name, false);
> -}
> -
> int ufs_qcom_phy_init_vregulators(struct ufs_qcom_phy *phy_common)
> {
> int err;
> @@ -284,9 +277,9 @@ int ufs_qcom_phy_init_vregulators(struct
> ufs_qcom_phy *phy_common)
> if (err)
> goto out;
>
> - /* vddp-ref-clk-* properties are optional */
> - __ufs_qcom_phy_init_vreg(phy_common->dev, &phy_common->vddp_ref_clk,
> - "vddp-ref-clk", true);
> + err = ufs_qcom_phy_init_vreg(phy_common->dev,
> &phy_common->vddp_ref_clk,
> + "vddp-ref-clk");
> +
> out:
> return err;
> }
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-20 22:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 10:47 [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource Bjorn Andersson
2017-01-19 10:47 ` [PATCH 2/4] phy: qcom-ufs: Correct usage of regulator_get() Bjorn Andersson
2017-01-19 19:33 ` vivek.gautam
2017-01-20 22:50 ` Subhash Jadavani [this message]
2017-01-19 10:47 ` [PATCH 3/4] phy: qcom-ufs: Remove -always-on property Bjorn Andersson
2017-01-19 19:39 ` Vivek Gautam
2017-01-20 22:53 ` Subhash Jadavani
2017-01-21 20:43 ` Rob Herring
2017-01-19 10:47 ` [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging Bjorn Andersson
2017-01-19 20:07 ` Vivek Gautam
2017-01-20 22:54 ` Subhash Jadavani
2017-01-19 20:09 ` [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource Vivek Gautam
2017-01-20 20:10 ` Subhash Jadavani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a810cc0c93dbceb15b8375450e4c7303@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).