From: Guenter Roeck <linux@roeck-us.net>
To: krishnar4 <krishnar@ami.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
Deepak Kodihalli <dkodihalli@nvidia.com>,
Shakeeb Pasha <spasha@nvidia.com>,
Vinodhini J <vinodhinij@ami.com>,
Pravinash Jeyapaul <pravinashj@ami.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false
Date: Tue, 25 Jan 2022 06:46:28 -0800 [thread overview]
Message-ID: <4e7ca9d8-c545-160a-5578-cf1438223759@roeck-us.net> (raw)
In-Reply-To: <20220125130116.18646-1-krishnar@ami.com>
On 1/25/22 05:01, krishnar4 wrote:
> Description: PSU can't use sysfs fan_target to control PSU fan duty.
>
This is neither a proper subject nor a proper description.
"modify PSU fan_target convert value to false" means that the
value reported from the attribute is used directly without
conversion. The subject should reflect this.
"Description:" should not be part of the description, and
the description should describe the reason for the change
(ie explain clearly what is wrong).
"PSU can't use sysfs fan_target to control PSU fan duty"
doesn't explain anything and doesn't match the subject.
> Signed-off-by: krishnar4 <krishnar@ami.com>
"krishnar4" is not an acceptable name. This needs to be a real name.
Guenter
> ---
> drivers/hwmon/pmbus/pmbus_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 776ee2237be2..a56c2e1c4079 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
>
> sensor = pmbus_add_sensor(data, "fan", "target", index, page,
> 0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
> - false, false, true);
> + false, false, false);
>
> if (!sensor)
> return -ENOMEM;
next prev parent reply other threads:[~2022-01-25 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 13:01 [PATCH linux dev-5.15] hwmon: (pmbus) modify PSU fan_target convert value to false krishnar4
2022-01-25 14:46 ` Guenter Roeck [this message]
[not found] <git-send-email-krishnar@ami.com>
2022-01-27 5:39 ` krishnar4
2022-01-27 6:04 ` krishnar4
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e7ca9d8-c545-160a-5578-cf1438223759@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=bgolaszewski@baylibre.com \
--cc=dkodihalli@nvidia.com \
--cc=joel@jms.id.au \
--cc=krishnar@ami.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pravinashj@ami.com \
--cc=spasha@nvidia.com \
--cc=vinodhinij@ami.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).