* [PATCH v2] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure
@ 2022-01-05 18:07 Lad Prabhakar
2022-01-05 18:10 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Lad Prabhakar @ 2022-01-05 18:07 UTC (permalink / raw)
To: Al Cooper, Greg Kroah-Hartman, Jiri Slaby
Cc: Andy Shevchenko, Florian Fainelli, Prabhakar, Lad Prabhakar,
linux-serial, bcm-kernel-feedback-list, linux-kernel
In case of dma_alloc_coherent() failure return -ENOMEM instead of
returning -EINVAL.
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
v1->v2
* Dropped fixes tag as suggested by Florian/Andy
---
drivers/tty/serial/8250/8250_bcm7271.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index cc60a7874e8b..9b878d023dac 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -1075,7 +1075,7 @@ static int brcmuart_probe(struct platform_device *pdev)
priv->rx_size,
&priv->rx_addr, GFP_KERNEL);
if (!priv->rx_bufs) {
- ret = -EINVAL;
+ ret = -ENOMEM;
goto err;
}
priv->tx_size = UART_XMIT_SIZE;
@@ -1083,7 +1083,7 @@ static int brcmuart_probe(struct platform_device *pdev)
priv->tx_size,
&priv->tx_addr, GFP_KERNEL);
if (!priv->tx_buf) {
- ret = -EINVAL;
+ ret = -ENOMEM;
goto err;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure
2022-01-05 18:07 [PATCH v2] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure Lad Prabhakar
@ 2022-01-05 18:10 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2022-01-05 18:10 UTC (permalink / raw)
To: Lad Prabhakar, Al Cooper, Greg Kroah-Hartman, Jiri Slaby
Cc: Andy Shevchenko, Prabhakar, linux-serial,
bcm-kernel-feedback-list, linux-kernel
On 1/5/22 10:07 AM, Lad Prabhakar wrote:
> In case of dma_alloc_coherent() failure return -ENOMEM instead of
> returning -EINVAL.
>
> Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> v1->v2
> * Dropped fixes tag as suggested by Florian/Andy
Thanks for the quick turnaround and carrying the tags forward. Cheers
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-05 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 18:07 [PATCH v2] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure Lad Prabhakar
2022-01-05 18:10 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).