From: Liu Ying <victor.liu@nxp.com>
To: Marek Vasut <marex@denx.de>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
krzysztof.kozlowski@linaro.org, LW@KARO-electronics.de,
alexander.stein@ew.tq-group.com
Subject: Re: [PATCH v2 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge
Date: Thu, 26 Jan 2023 10:10:38 +0800 [thread overview]
Message-ID: <4ec549dcec8686b9d1eed619965fde0b17736f17.camel@nxp.com> (raw)
In-Reply-To: <d035621a-33a6-ca38-1bb3-726b3dd0eab4@denx.de>
On Wed, 2023-01-25 at 14:56 +0100, Marek Vasut wrote:
> On 1/25/23 07:40, Liu Ying wrote:
> > A valid bridge is already found in lcdif_attach_bridge() and set
> > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
> > the unnecessary NULL pointer check in KMS stage.
>
> Is it possible that a panel (instead of a bridge) be attached to
> LCDIFv3
> e.g. in case of iMXRT ?
According to IMXRT1160 and IMXRT1170 reference manuals, it looks like
LCDIFv2(similar to LCDIFv3, but not the same) may connect to a parallel
display panel through a mux(either eLCDIF or LCDIFv2). That mux could
be a bridge. But, it doesn't matter, because devm_drm_of_get_bridge()
may create a panel bridge if a panel is connected directly(See
kerneldoc of devm_drm_of_get_bridge()).
Regards,
Liu Ying
>
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v1->v2:
> > * Split from patch 2/2 in v1. (Marek, Alexander)
>
> Much appreciated, thanks.
>
> [...]
next prev parent reply other threads:[~2023-01-26 2:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 6:40 [PATCH v2 0/6] drm: lcdif: Add i.MX93 LCDIF support Liu Ying
2023-01-25 6:40 ` [PATCH v2 1/6] dt-bindings: " Liu Ying
2023-01-25 6:40 ` [PATCH v2 2/6] drm: lcdif: Drop unnecessary NULL pointer check on lcdif->bridge Liu Ying
2023-01-25 13:56 ` Marek Vasut
2023-01-26 2:10 ` Liu Ying [this message]
2023-01-25 6:40 ` [PATCH v2 3/6] drm: lcdif: Determine bus format and flags in ->atomic_check() Liu Ying
2023-01-25 6:40 ` [PATCH v2 4/6] drm: lcdif: Check consistent bus format and flags across first bridges Liu Ying
2023-01-25 6:40 ` [PATCH v2 5/6] drm: lcdif: Add multiple encoders and first bridges support Liu Ying
2023-01-25 6:40 ` [PATCH v2 6/6] drm: lcdif: Add i.MX93 LCDIF compatible string Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec549dcec8686b9d1eed619965fde0b17736f17.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=LW@KARO-electronics.de \
--cc=airlied@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).