* [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
@ 2018-12-09 6:34 YueHaibing
2018-12-10 6:15 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2018-12-09 6:34 UTC (permalink / raw)
To: dmitry.torokhov, matthias.bgg, lee.jones, chen.zhong
Cc: linux-kernel, linux-mediatek, linux-arm-kernel, linux-input, YueHaibing
Remove duplicated include.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/input/keyboard/mtk-pmic-keys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
index 02c67a1..5027ebb 100644
--- a/drivers/input/keyboard/mtk-pmic-keys.c
+++ b/drivers/input/keyboard/mtk-pmic-keys.c
@@ -19,7 +19,6 @@
#include <linux/input.h>
#include <linux/interrupt.h>
#include <linux/platform_device.h>
-#include <linux/kernel.h>
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/regmap.h>
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
2018-12-09 6:34 [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c YueHaibing
@ 2018-12-10 6:15 ` Lee Jones
2018-12-10 7:16 ` YueHaibing
0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2018-12-10 6:15 UTC (permalink / raw)
To: YueHaibing
Cc: dmitry.torokhov, matthias.bgg, chen.zhong, linux-kernel,
linux-mediatek, linux-arm-kernel, linux-input
On Sun, 09 Dec 2018, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/input/keyboard/mtk-pmic-keys.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
> index 02c67a1..5027ebb 100644
> --- a/drivers/input/keyboard/mtk-pmic-keys.c
> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
> @@ -19,7 +19,6 @@
> #include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/platform_device.h>
> -#include <linux/kernel.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/regmap.h>
You are removing the wrong one.
Please convert this patch's main intent to alphabetise the header
files. Then you can remove any obvious duplicates.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
2018-12-10 6:15 ` Lee Jones
@ 2018-12-10 7:16 ` YueHaibing
2018-12-10 10:07 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2018-12-10 7:16 UTC (permalink / raw)
To: Lee Jones
Cc: dmitry.torokhov, matthias.bgg, chen.zhong, linux-kernel,
linux-mediatek, linux-arm-kernel, linux-input
On 2018/12/10 14:15, Lee Jones wrote:
> On Sun, 09 Dec 2018, YueHaibing wrote:
>
>> Remove duplicated include.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/input/keyboard/mtk-pmic-keys.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
>> index 02c67a1..5027ebb 100644
>> --- a/drivers/input/keyboard/mtk-pmic-keys.c
>> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
>> @@ -19,7 +19,6 @@
>> #include <linux/input.h>
>> #include <linux/interrupt.h>
>> #include <linux/platform_device.h>
>> -#include <linux/kernel.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> #include <linux/regmap.h>
>
> You are removing the wrong one.
No, linux/kernel.h is a duplicated include indeed.
>
> Please convert this patch's main intent to alphabetise the header
> files. Then you can remove any obvious duplicates.
I can alphabetize it in v2 if need be.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
2018-12-10 7:16 ` YueHaibing
@ 2018-12-10 10:07 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2018-12-10 10:07 UTC (permalink / raw)
To: YueHaibing
Cc: dmitry.torokhov, matthias.bgg, chen.zhong, linux-kernel,
linux-mediatek, linux-arm-kernel, linux-input
On Mon, 10 Dec 2018, YueHaibing wrote:
> On 2018/12/10 14:15, Lee Jones wrote:
> > On Sun, 09 Dec 2018, YueHaibing wrote:
> >
> >> Remove duplicated include.
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >> drivers/input/keyboard/mtk-pmic-keys.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c
> >> index 02c67a1..5027ebb 100644
> >> --- a/drivers/input/keyboard/mtk-pmic-keys.c
> >> +++ b/drivers/input/keyboard/mtk-pmic-keys.c
> >> @@ -19,7 +19,6 @@
> >> #include <linux/input.h>
> >> #include <linux/interrupt.h>
> >> #include <linux/platform_device.h>
> >> -#include <linux/kernel.h>
> >> #include <linux/of.h>
> >> #include <linux/of_device.h>
> >> #include <linux/regmap.h>
> >
> > You are removing the wrong one.
>
> No, linux/kernel.h is a duplicated include indeed.
Actually both are not correct, but the first instance (at the top) is
even more incorrect.
> > Please convert this patch's main intent to alphabetise the header
> > files. Then you can remove any obvious duplicates.
>
> I can alphabetize it in v2 if need be.
Yes please.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-10 10:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-09 6:34 [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c YueHaibing
2018-12-10 6:15 ` Lee Jones
2018-12-10 7:16 ` YueHaibing
2018-12-10 10:07 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).