From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Joao Martins <joao.m.martins@oracle.com>, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org,
devel@acpica.org, Erik Schmauss <erik.schmauss@intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too
Date: Thu, 8 Mar 2018 17:33:56 -0500 [thread overview]
Message-ID: <4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com> (raw)
In-Reply-To: <20180308105751.8176-1-joao.m.martins@oracle.com>
On 03/08/2018 05:57 AM, Joao Martins wrote:
> @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv)
>
> pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk);
>
> + /* It has P-state dependencies */
> + if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) {
> + __set_bit(acpi_id, acpi_id_psd_present);
> +
> + pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n",
> + acpi_id, acpi_psd[acpi_id].coord_type,
> + acpi_psd[acpi_id].domain);
> + }
I should have noticed this earlier, but do you really need
acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL?
Sorry for missing it in the first patch.
-boris
next prev parent reply other threads:[~2018-03-08 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 10:57 [PATCH v2] xen/acpi: upload _PSD info for non Dom0 CPUs too Joao Martins
2018-03-08 22:33 ` Boris Ostrovsky [this message]
2018-03-09 12:56 ` [Xen-devel] " Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=jgross@suse.com \
--cc=joao.m.martins@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).