From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>
Cc: ~okias/devicetree@lists.sr.ht,
Caleb Connolly <caleb@connolly.tech>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC
Date: Sun, 10 Apr 2022 10:37:59 +0200 [thread overview]
Message-ID: <4f20ad11-40c5-638e-7335-c68d2369373d@linaro.org> (raw)
In-Reply-To: <20220111220026.102838-1-david@ixit.cz>
On 11/01/2022 23:00, David Heidelberg wrote:
> Convert Qualcomm SPMI PMIC binding to yaml format.
>
> Additional changes:
> - filled many missing compatibles
>
> Co-developed-by: Caleb Connolly <caleb@connolly.tech>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
Thank you for your patch. There is something to discuss/improve.
(...)
> +
> + compatible:
> + items:
> + - enum:
> + - qcom,pm660
> + - qcom,pm660l
> + - qcom,pm6150
> + - qcom,pm6150l
> + - qcom,pm6350
> + - qcom,pm7325
> + - qcom,pm8004
> + - qcom,pm8005
> + - qcom,pm8009
> + - qcom,pm8019
> + - qcom,pm8110
> + - qcom,pm8150
> + - qcom,pm8150b
> + - qcom,pm8150l
> + - qcom,pm8226
> + - qcom,pm8350
> + - qcom,pm8350b
> + - qcom,pm8350c
> + - qcom,pm8841
> + - qcom,pm8909
> + - qcom,pm8916
> + - qcom,pm8941
> + - qcom,pm8950
> + - qcom,pm8994
> + - qcom,pm8998
> + - qcom,pma8084
> + - qcom,pmd9635
> + - qcom,pmi8950
> + - qcom,pmi8962
> + - qcom,pmi8994
> + - qcom,pmi8998
> + - qcom,pmk8350
> + - qcom,pmm8155au
> + - qcom,pmr735a
> + - qcom,pmr735b
> + - qcom,pms405
> + - qcom,pmx55
> + - qcom,smb2351
> + - const: qcom,spmi-pmic
> +
> + reg: true
maxItems
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +
Just one blank line.
> +patternProperties:
> + '^(labibb|([a-z][a-z0-9]+-)?regulators)$':
> + type: object
> +
This should be more specific, preferably by including schema for
regulators (or any other children if applicable).
> + required:
> + - compatible
unevaluatedProperties: false
> +
> + '@[0-9a-f]+$':
> + type: object
> + description: >
You don't need '>'.
This also should be specified - what is expected to be here? Usually the
children are exactly known.
> + Each child node of the PMIC represents a function of it.
> +
> + properties:
> + reg: true
maxItems
> +
> + interrupts:
> + description: >
No need for >
> + Interrupts are specified as a 4-tuple. For more information see
> + Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> +
> + required:
> + - compatible
> +
> + additionalProperties: true
This will have to unevaluated or additional properties false, depending
whether you include other schema or not.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
Best regards,
Krzysztof
prev parent reply other threads:[~2022-04-10 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 22:00 [PATCH v2] dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC David Heidelberg
2022-01-22 0:47 ` Rob Herring
2022-04-10 8:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f20ad11-40c5-638e-7335-c68d2369373d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).