From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: "Christian A. Ehrhardt" <lk@c--e.de>,
niklas.neronin@linux.intel.com,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-x86_64@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: This is the fourth time I’ve tried to find what led to the regression of outgoing network speed and each time I find the merge commit 8c94ccc7cd691472461448f98e2372c75849406c
Date: Wed, 21 Feb 2024 15:44:47 +0200 [thread overview]
Message-ID: <4f34b6a8-4415-6ea4-8090-262847d606c6@linux.intel.com> (raw)
In-Reply-To: <10487018-49b8-4b27-98a1-07cee732290d@infradead.org>
On 21.2.2024 1.43, Randy Dunlap wrote:
>
>
> On 2/20/24 15:41, Randy Dunlap wrote:
>> {+ tglx]
>
> (this time for real)
>
>>
>> On 2/20/24 15:19, Mikhail Gavrilov wrote:
>>> On Mon, Feb 19, 2024 at 2:41 PM Mikhail Gavrilov
>>> <mikhail.v.gavrilov@gmail.com> wrote:
>>>>
>>>> I installed irqbalance daemon and nothing changed.
>>>> So who is responsible for irq balancing?
>>>
>>> Sorry for the noise. Can anyone give me an answer?
>>> Who is responsible for distributing interrupts in Linux?
>>> I spotted network performance regression and it turned out, this was
>>> due to the network card getting other interrupt. It is a side effect
>>> of commit 57e153dfd0e7a080373fe5853c5609443d97fa5a.
>>
>> That's a merge commit (AFAIK, maybe not so much). The commit in mainline is:
>>
>> commit f977f4c9301c
>> Author: Niklas Neronin <niklas.neronin@linux.intel.com>
>> Date: Fri Dec 1 17:06:40 2023 +0200
>>
>> xhci: add handler for only one interrupt line
>>
>>> Installing irqbalance daemon did not help. Maybe someone experienced
>>> such a problem?
>>>
>>
>> Thomas, would you look at this, please?
>>
>> A network device and xhci (USB) driver are now sharing interrupts.
>> This causes a large performance decrease for the networking device.
Short recap:
xhci (USB) and network device didn't share interrupts, or even interrupt the
same CPU in either good or bad case.
A change in how many interrupts xhci driver requests changed which CPU
the network device interrupts.
In the bad case Mikhail Gavrilovs network device was interrupting CPU0
together with:
- IR-IO-APIC 2-edge timer
- IR-PCI-MSIX-0000:07:00.0 1-edge nvme1q1
In the good case network device was interrupting CPU27 together with:
- IR-PCI-MSIX-0000:04:00.0 27-edge nvme0q27
- IR-PCI-MSIX-0000:07:00.0 28-edge nvme1q28
Manually moving network device irq 87 from CPU0 to CPU23 helped.
(echo 800000 > /proc/irq/87/smp_affinity)
Thanks
-Mathias
next prev parent reply other threads:[~2024-02-21 13:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 1:02 This is the fourth time I’ve tried to find what led to the regression of outgoing network speed and each time I find the merge commit 8c94ccc7cd691472461448f98e2372c75849406c Mikhail Gavrilov
2024-02-03 1:08 ` Rahul Rameshbabu
2024-02-03 1:15 ` Randy Dunlap
2024-02-03 1:16 ` Randy Dunlap
2024-02-03 2:32 ` Jakub Kicinski
2024-02-03 18:20 ` Christian A. Ehrhardt
2024-02-04 20:47 ` Christian A. Ehrhardt
2024-02-05 21:08 ` Mikhail Gavrilov
2024-02-06 11:26 ` Mathias Nyman
2024-02-06 16:12 ` Mikhail Gavrilov
2024-02-07 10:40 ` Mathias Nyman
2024-02-07 11:55 ` Mikhail Gavrilov
2024-02-08 9:25 ` Mathias Nyman
2024-02-08 10:32 ` Mikhail Gavrilov
2024-02-08 15:43 ` Mathias Nyman
2024-02-16 6:15 ` This is the fourth time Iâve " Linux regression tracking (Thorsten Leemhuis)
2024-02-19 9:41 ` This is the fourth time I’ve " Mikhail Gavrilov
2024-02-20 23:19 ` Mikhail Gavrilov
2024-02-20 23:41 ` Randy Dunlap
2024-02-20 23:43 ` Randy Dunlap
2024-02-21 13:44 ` Mathias Nyman [this message]
2024-02-26 5:45 ` This is the fourth time I've " Linux regression tracking (Thorsten Leemhuis)
2024-02-26 9:24 ` Mathias Nyman
2024-02-26 9:51 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-26 10:54 ` Mathias Nyman
2024-02-26 18:09 ` Thomas Gleixner
2024-02-27 17:08 ` mikhail.v.gavrilov
2024-02-27 17:23 ` Thomas Gleixner
[not found] ` <960fd112b294a902e1bea1fdd8e04a708a05cf45.camel@gmail.com>
2024-02-29 9:41 ` Mikhail Gavrilov
2024-03-04 14:10 ` Linux regression tracking (Thorsten Leemhuis)
2024-02-21 6:48 ` This is the fourth time I’ve " Linux regression tracking #adding (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f34b6a8-4415-6ea4-8090-262847d606c6@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-x86_64@vger.kernel.org \
--cc=lk@c--e.de \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.neronin@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).