* Re: [PATCH] selftests: ftrace: Fixes for the testing script ftracetest
[not found] <20180510152108.19750-1-ahiliation@yahoo.co.in>
@ 2018-05-10 15:33 ` Shuah Khan
0 siblings, 0 replies; only message in thread
From: Shuah Khan @ 2018-05-10 15:33 UTC (permalink / raw)
To: Jeffrin Jose T, rostedt, mingo
Cc: linux-kselftest, linux-kernel, Jeffrin Jose T, Shuah Khan
On 05/10/2018 09:21 AM, Jeffrin Jose T wrote:
> modified notification of permission requirement to run test
> to make it unified with standards
>
> Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
> ---
> tools/testing/selftests/ftrace/ftracetest | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index f9a9d424c980..0cc967344c07 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>
> # ftracetest - Ftrace test shell scripts
> #
> @@ -29,8 +29,11 @@ errexit() { # message
> }
>
> # Ensuring user privilege
> -if [ `id -u` -ne 0 ]; then
> - errexit "this must be run by root user"
> +msg="skip all tests:"
> +
> +if [ $UID != 0 ]; then
> + echo $msg please run this as root >&2
> + exit $ksft_skip
> fi
>
> # Utilities
>
Hi Jeffrin,
I already have a patch out for this. Please make sure you aren't doing
duplicate work.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] only message in thread