From: Jaehoon Chung <jh80.chung@samsung.com>
To: Doug Anderson <dianders@chromium.org>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Will Newton <will.newton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
linux-kernel@vger.kernel.org,
Grant Grundler <grundler@chromium.org>,
Olof Johansson <olofj@chromium.org>,
shashidharh@vayavyalabs.com, ki0351.kim@samsung.com
Subject: Re: [PATCH v3] mmc: dw_mmc: Disable low power mode if SDIO interrupts are used
Date: Wed, 25 Jul 2012 19:02:16 +0900 [thread overview]
Message-ID: <500FC428.8030305@samsung.com> (raw)
In-Reply-To: <1343149145-22927-1-git-send-email-dianders@chromium.org>
> +
> static void dw_mci_enable_sdio_irq(struct mmc_host *mmc, int enb)
> {
> struct dw_mci_slot *slot = mmc_priv(mmc);
> @@ -871,6 +898,14 @@ static void dw_mci_enable_sdio_irq(struct mmc_host *mmc, int enb)
> /* Enable/disable Slot Specific SDIO interrupt */
> int_mask = mci_readl(host, INTMASK);
> if (enb) {
> + /*
> + * Turn off low power mode if it was enabled. This is a bit of
> + * a heavy operation and we disable / enable IRQs a lot, so
> + * we'll leave low power mode disabled and it will get
> + * re-enabled again in dw_mci_setup_bus().
> + */
> + dw_mci_disable_low_power(mmc_priv(mmc));
Just use the slot. slot is already assigned to mmc_priv(mmc)
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
next prev parent reply other threads:[~2012-07-25 10:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 18:13 [PATCH] mmc: dw_mmc: Disable low power mode if SDIO interrupts are used Doug Anderson
2012-07-21 10:40 ` Will Newton
2012-07-23 2:48 ` Doug Anderson
2012-07-23 9:19 ` Will Newton
2012-07-23 17:00 ` Doug Anderson
2012-07-23 17:02 ` [PATCH v2] " Doug Anderson
2012-07-24 1:17 ` Seungwon Jeon
2012-07-24 16:58 ` Doug Anderson
2012-07-24 1:36 ` Jaehoon Chung
2012-07-24 16:58 ` Doug Anderson
2012-07-24 16:59 ` [PATCH v3] " Doug Anderson
2012-07-25 9:11 ` Will Newton
2012-07-25 10:02 ` Jaehoon Chung [this message]
2012-07-25 15:32 ` Doug Anderson
2012-07-25 15:33 ` [PATCH v4] " Doug Anderson
2012-07-26 4:00 ` Seungwon Jeon
2012-08-08 3:40 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FC428.8030305@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=dianders@chromium.org \
--cc=grundler@chromium.org \
--cc=james.hogan@imgtec.com \
--cc=ki0351.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=shashidharh@vayavyalabs.com \
--cc=tgih.jun@samsung.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).